Add missing example for Thread struct #38548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis found some issues. |
frewsxcv
reviewed
Dec 22, 2016
| /// .unwrap(); | ||
| /// | ||
| /// handler.join().unwrap(); | ||
| /// ``` |
There was a problem hiding this comment.
Where is Thread used in this example?
There was a problem hiding this comment.
In the spawn closure.
frewsxcv
reviewed
Dec 22, 2016
| /// .unwrap(); | ||
| /// | ||
| /// handler.join().unwrap(); | ||
| /// ``` |
There was a problem hiding this comment.
What is unpark doing in this example?
There was a problem hiding this comment.
Not much, I really wonder how to show such an example of usage actually... :-/
GuillaumeGomez
force-pushed
the
thread_struct_docs
branch
from
ab1275f
to
3372d9c
Compare
|
Updated. |
frewsxcv
reviewed
Dec 31, 2016
| /// use std::thread; | ||
| /// | ||
| /// let handler = thread::Builder::new() | ||
| /// .name("foo".into()); |
| /// let handler = thread::Builder::new() | ||
| /// .spawn(|| { | ||
| /// let thread = thread::current(); | ||
| /// println!("thread id: {}", thread.id()); |
There was a problem hiding this comment.
ThreadId does not implement Display
GuillaumeGomez
force-pushed
the
thread_struct_docs
branch
from
3372d9c
to
3312feb
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 3312feb has been approved by |
bors
added a commit
that referenced
this pull request
Jan 1, 2017
Add missing example for Thread struct r? @frewsxcv
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @frewsxcv