Remove duplicated "parameter" in E0089 text #39758
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
src/test/compile-fail/E0089.rs
Outdated
| foo::<f64>(); | ||
| //~^ ERROR E0089 | ||
| //~| NOTE expected 2 type parameters | ||
| foo::<f64>(); //~ ERROR expected 2 parameters, found 1 parameter [E0089] |
There was a problem hiding this comment.
This sentence is invalid actually... It needs to speak about type parameters and not just parameter.
There was a problem hiding this comment.
@GuillaumeGomez it does actually, it's just not repeating "type parameter" throughout the entire message:
error[E0089]: too few type parameters provided: expected 2 parameters parameters, found 1 parameter parameter
(emphasis mine)
There was a problem hiding this comment.
Yes, but repeating things is a good thing from my point of view. It allows to have coherent error messages.
shepmaster
force-pushed
the
e0089-duplicate-text
branch
from
82f8f3f
to
3d0b83d
Compare
|
@GuillaumeGomez I've added a second commit that adds the requested "type" or "lifetime" text. Since I was making a larger change, I went ahead and normalized the 4 related errors and their tests. |
|
Awesome, thanks! Once the tidy issue is fixed: I'll r+ it. |
They now always say how many lifetime / type parameters were expected and are explicit about stating "lifetime" or "type" instead of just "parameter".
shepmaster
force-pushed
the
e0089-duplicate-text
branch
from
3d0b83d
to
1c99841
Compare
|
@GuillaumeGomez I always fail to check tidy. Fixed now. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 1c99841 has been approved by |
…GuillaumeGomez Remove duplicated "parameter" in E0089 text Closes rust-lang#39732
Closes #39732