Update mdbook version #39966
Merged
Update mdbook version #39966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
4 tasks
|
@bors: r+ rollup |
|
📌 Commit 4cc4944 has been approved by |
This version of mdbook includes https://github.com/azerupi/mdBook/pull/207 , which is needed so that we can start doing linkchecker on the various books.
In order to update mdbook, we have to update other stuff too.
steveklabnik
force-pushed
the
update-mdbook
branch
from
4cc4944
to
2795de3
Compare
|
@bors: r=GuillaumeGomez rollup I didn't notice we needed to update other deps too, oops 😓 |
|
📌 Commit 2795de3 has been approved by |
10 tasks
|
@bors: p=1 (All the other commits in the queue are r+'d by me, I'd like this one to land first) |
|
⌛ Testing commit 2795de3 with merge bcd62ac... |
|
💔 Test failed - status-appveyor |
|
@bors: retry |
|
⌛ Testing commit 2795de3 with merge 322f0d7... |
bors
added a commit
that referenced
this pull request
Feb 20, 2017
Update mdbook version This version of mdbook includes https://github.com/azerupi/mdBook/pull/207 , which is needed so that we can start doing linkchecker on the various books.
|
☀️ Test successful - status-appveyor, status-travis |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 20, 2017
This reverts commit 7f1d1c6. The original commit was created because mdBook and rustdoc had different generation algorithms for header links; now with rust-lang#39966 , the algorithms are the same. So let's undo this change. ... when I came across this problem, I said "eh, this isn't fun, but it doesn't take that long." I probably should have just actually taken the time to fix upstream, given that they were amenable. Oh well!
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 20, 2017
Previously, mdBook used JavaScript to add header links, so we skipped checking the book. As of rust-lang#39966, it no longer does, so we can start checking again. There is a twist, though: it uses name instead of id, so let's test for both. They're both valid links anyway, so it's good to have the checker check anyway.
anatol
pushed a commit
to anatol/steed
that referenced
this pull request
Mar 31, 2017
This reverts commit 7f1d1c6d9a7be5e427bace30e740b16b25f25c92. The original commit was created because mdBook and rustdoc had different generation algorithms for header links; now with rust-lang/rust#39966 , the algorithms are the same. So let's undo this change. ... when I came across this problem, I said "eh, this isn't fun, but it doesn't take that long." I probably should have just actually taken the time to fix upstream, given that they were amenable. Oh well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of mdbook includes
https://github.com/azerupi/mdBook/pull/207 , which is needed so that
we can start doing linkchecker on the various books.