Rollup of 12 pull requests #40446
Merged
Rollup of 12 pull requests #40446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arielb1
commented
Mar 11, 2017
arielb1
commented
- Successful merges: Better docs of rusty parts of typeck #40146, Add missing example for Display::fmt #40299, Allow lints to check Bodys directly #40315, Disallow subtyping between T and U in T: Unsize<U>. #40319, save-analysis: cope with lack of method data after a type error #40344, Fix missing backtick typo #40345, Do not bother creating StorageLive for TyNever #40372, Fix UB in repr(packed) tests #40373, Update gdbr tests #40400, fix #40294 obligation cause.body_id is not always a NodeExpr #40404, Fix associated consts display #40419, rustc: Whitelist the FMA target feature #40431
- Failed merges:
Fixes rendering of the end of the `Configure and Make` section.
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
gdb will now reliably detect the lanugage as rust even before any code is run.
This commit adds the entry `"fma\0"` to the whitelist for the x86 target. LLVM already supports fma but rustc did not directly. Previously rustc permitted `+fma` in the target-feature argument and enabled the use of FMA instructions, but it did not list it in the configuration and attributes. fixes rust-lang#40406
This should hopefully add support for debugging OSX and Windows presumed sccache failures instead of just the Linux ones.
Better docs of rusty parts of typeck
… r=frewsxcv Add missing example for Display::fmt r? @frewsxcv
Allow lints to check Bodys directly r? @eddyb babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))
…r=nikomatsakis Disallow subtyping between T and U in T: Unsize<U>. Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288. E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes. Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).
save-analysis: cope with lack of method data after a type error Fixes rust-lang#39957 r? @eddyb
Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.
Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb
|
💔 Test failed - status-travis |
Network failure @bors retry |
|
⌛ Testing commit b1e03fe with merge 4674a74... |
|
💔 Test failed - status-travis |
|
… On Sat, Mar 11, 2017 at 4:48 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/210145637>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40446 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95G0K-pgJ51H1sY8bcrwo-X3pXT2Fks5rkySogaJpZM4MaUNa>
.
|
|
@bors: p=2 |
|
⌛ Testing commit b1e03fe with merge bf4151b... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
|
|
⌛ Testing commit b1e03fe with merge 9ae5edd... |
|
💔 Test failed - status-travis |
|
@bors: r+ |
|
📌 Commit 6a5fd0f has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Mar 12, 2017
Merged
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 20, 2017
I have a suspicion that this caused a large regression in cycle times by forcing the compiler to perform more checks on every `debug!` statement, so let's test this out by removing the `RUST_LOG` env var globally. This regression in cycle time was witnessed between [two] [builds] where the [PR] in question didn't do much suspicious. Judging by how the stage0 times *also* regressed though then this is my best guess. [two]: https://travis-ci.org/rust-lang/rust/builds/210149932 [builds]: https://travis-ci.org/rust-lang/rust/builds/210179995 [PR]: rust-lang#40446
bors
added a commit
that referenced
this pull request
Mar 21, 2017
travis: Don't set `RUST_LOG` globally I have a suspicion that this caused a large regression in cycle times by forcing the compiler to perform more checks on every `debug!` statement, so let's test this out by removing the `RUST_LOG` env var globally. This regression in cycle time was witnessed between [two] [builds] where the [PR] in question didn't do much suspicious. Judging by how the stage0 times *also* regressed though then this is my best guess. [two]: https://travis-ci.org/rust-lang/rust/builds/210149932 [builds]: https://travis-ci.org/rust-lang/rust/builds/210179995 [PR]: #40446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.