appveyor: Use Ninja to build LLVM on MinGW #40548
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
(Unrelated, but ninja is a good thing to use for at least the three major platforms) |
|
Yeah I was thinking that if we start going in this direction we may as well use Ninja on all platforms as it provides a nice cross-platform experience for the builders at least (and hopefully reduces the surface area for bugs...) |
|
@bors r+ |
|
📌 Commit 18423e5 has been approved by |
|
🔒 Merge conflict |
retep998
force-pushed
the
appveyor-ninja
branch
from
18423e5
to
845d193
Compare
|
@bors r=brson |
|
📌 Commit 845d193 has been approved by |
|
@bors: p=1 #40546 has caused what I believe are 6 spurious failures and I think this is the solution, so let's try to stabilize our builds. |
|
⌛ Testing commit 845d193 with merge 054d0da... |
|
💔 Test failed - status-appveyor |
alexcrichton
force-pushed
the
appveyor-ninja
branch
from
845d193
to
d0ac908
Compare
|
@bors: r=brson |
|
📌 Commit d0ac908 has been approved by |
|
🔒 Merge conflict |
alexcrichton
force-pushed
the
appveyor-ninja
branch
from
d0ac908
to
963b525
Compare
|
@bors: r=brson |
|
📌 Commit 963b525 has been approved by |
|
⌛ Testing commit 963b525 with merge 8355ad9... |
|
💔 Test failed - status-appveyor |
|
@bors: r=brson |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 963b525 has been approved by |
I have a suspicion that MinGW's make is the cause of rust-lang#40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes rust-lang#40546 for real, but this is my current best shot at closing it out, so... Closes rust-lang#40546
alexcrichton
force-pushed
the
appveyor-ninja
branch
from
963b525
to
6ae2234
Compare
|
@bors: r=brson |
|
📌 Commit 6ae2234 has been approved by |
|
⌛ Testing commit 6ae2234 with merge ca2f437... |
|
💔 Test failed - status-appveyor |
|
… On Wed, Mar 22, 2017 at 6:53 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2485>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40548 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EqvqDh9f7jyhRPIYraQkxvBQ4hRks5roQvEgaJpZM4MeB5w>
.
|
appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of #40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes #40546 for real, but this is my current best shot at closing it out, so... Closes #40546
|
💔 Test failed - status-travis |
|
… On Wed, Mar 22, 2017 at 10:50 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/213853641>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40548 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95LMhDCUHj_kvTDoIb5o7gzh4wRLgks5roUM0gaJpZM4MeB5w>
.
|
appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of #40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes #40546 for real, but this is my current best shot at closing it out, so... Closes #40546
|
This is not making progress. No point in making in waiting any longer. @bors retry For posterity: https://s3.amazonaws.com/archive.travis-ci.org/jobs/213962210/log.txt |
|
⌛ Testing commit 6ae2234 with merge b8e178c... |
appveyor: Use Ninja to build LLVM on MinGW I have a suspicion that MinGW's make is the cause of rust-lang#40546 rather than anything else, but that's purely a suspicion without any facts to back it up. In any case we'll eventually be moving the MSVC build over to Ninja in order to leverage sccache regardless, so this commit simply jumpstarts that process by downloading Ninja for use by MinGW anyway. I'm not sure if this closes rust-lang#40546 for real, but this is my current best shot at closing it out, so... Closes rust-lang#40546
|
@bors retry rollup includes this pr |
|
Thanks @frewsxcv! BTW that error looks like the linux machine literally shut down, and it seems that Travis may not handle that gracefully... |
I have a suspicion that MinGW's make is the cause of #40546 rather than anything
else, but that's purely a suspicion without any facts to back it up. In any case
we'll eventually be moving the MSVC build over to Ninja in order to leverage
sccache regardless, so this commit simply jumpstarts that process by downloading
Ninja for use by MinGW anyway.
I'm not sure if this closes #40546 for real, but this is my current best shot at
closing it out, so...
Closes #40546