-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 22 pull requests #40644
Rollup of 22 pull requests #40644
Commits on Mar 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c7db40f - Browse repository at this point
Copy the full SHA c7db40fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50aee36 - Browse repository at this point
Copy the full SHA 50aee36View commit details
Commits on Mar 11, 2017
-
Point to let when modifying field of immutable variable
Point at the immutable local variable when trying to modify one of its fields. Given a file: ```rust struct Foo { pub v: Vec<String> } fn main() { let f = Foo { v: Vec::new() }; f.v.push("cat".to_string()); } ``` present the following output: ``` error: cannot borrow immutable field `f.v` as mutable --> file.rs:7:13 | 6 | let f = Foo { v: Vec::new() }; | - this should be `mut` 7 | f.v.push("cat".to_string()); | ^^^ error: aborting due to previous error ```
Configuration menu - View commit details
-
Copy full SHA for 6ba494b - Browse repository at this point
Copy the full SHA 6ba494bView commit details
Commits on Mar 12, 2017
-
Change label to "consider changing this to
mut f
"Change the wording of mutable borrow on immutable binding from "this should be `mut`" to "consider changing this to `mut f`".
Configuration menu - View commit details
-
Copy full SHA for 38b5b29 - Browse repository at this point
Copy the full SHA 38b5b29View commit details
Commits on Mar 13, 2017
-
Initial attempt at implementing optimization fuel and re-enabling str…
…uct field reordering.
Configuration menu - View commit details
-
Copy full SHA for 197e529 - Browse repository at this point
Copy the full SHA 197e529View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f36057 - Browse repository at this point
Copy the full SHA 8f36057View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d14fc - Browse repository at this point
Copy the full SHA c2d14fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fb94b7 - Browse repository at this point
Copy the full SHA 3fb94b7View commit details
Commits on Mar 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9ac628d - Browse repository at this point
Copy the full SHA 9ac628dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 460bf55 - Browse repository at this point
Copy the full SHA 460bf55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c1cc6 - Browse repository at this point
Copy the full SHA 68c1cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 839c286 - Browse repository at this point
Copy the full SHA 839c286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e02bd - Browse repository at this point
Copy the full SHA 85e02bdView commit details -
Add feature toggle for rvalue-static-promotion RFC
See rust-lang/rfcs#1414. Updates rust-lang#38865.
Configuration menu - View commit details
-
Copy full SHA for b43c744 - Browse repository at this point
Copy the full SHA b43c744View commit details -
It does not seem valuable to always evaluate the right-hand side here.
Configuration menu - View commit details
-
Copy full SHA for 20c0f32 - Browse repository at this point
Copy the full SHA 20c0f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for f06b049 - Browse repository at this point
Copy the full SHA f06b049View commit details -
add test for nested macro def (rust-lang#31946)
Adds a test for issue rust-lang#31946 which was fixed a while ago.
Configuration menu - View commit details
-
Copy full SHA for 9741c9d - Browse repository at this point
Copy the full SHA 9741c9dView commit details
Commits on Mar 15, 2017
-
make shift builtins panic-free with new unchecked_sh* intrinsics
Also update some 128 bit builtins to be panic-free without relying on the const evaluator.
Configuration menu - View commit details
-
Copy full SHA for cc23d17 - Browse repository at this point
Copy the full SHA cc23d17View commit details -
Change how the
0
flag works in format!Now it always implies right-alignment, so that padding zeroes are placed after the sign (if any) and before the digits. In other words, it always takes precedence over explicitly specified `[[fill]align]`. This also affects the '#' flag: zeroes are placed after the prefix (0b, 0o, 0x) and before the digits. :05 :<05 :>05 :^05 before |-0001| |-1000| |-0001| |-0100| after |-0001| |-0001| |-0001| |-0001| :#05x :<#05x :>#05x :^#05x before |0x001| |0x100| |000x1| |0x010| after |0x001| |0x001| |0x001| |0x001| Fixes rust-lang#39997 [breaking-change]
Configuration menu - View commit details
-
Copy full SHA for ff63866 - Browse repository at this point
Copy the full SHA ff63866View commit details -
Change how the 0 flag works in format! for floats
Now it always implies right-alignment, so that padding zeroes are placed after the sign (if any) and before the digits. In other words, it always takes precedence over explicitly specified `[[fill]align]`. :06 :<06 :>06 :^06 before |-001.2| |-1.200| |-001.2| |-01.20| after |-001.2| |-001.2| |-001.2| |-001.2|
Configuration menu - View commit details
-
Copy full SHA for 8065486 - Browse repository at this point
Copy the full SHA 8065486View commit details -
Configuration menu - View commit details
-
Copy full SHA for c11ab21 - Browse repository at this point
Copy the full SHA c11ab21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 310f5bd - Browse repository at this point
Copy the full SHA 310f5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cf22cb - Browse repository at this point
Copy the full SHA 4cf22cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce616a7 - Browse repository at this point
Copy the full SHA ce616a7View commit details
Commits on Mar 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9b89274 - Browse repository at this point
Copy the full SHA 9b89274View commit details -
Check for conflicts between macros 1.0 exports (
#[macro_export]
, `#……[macro_reexport]`) and macros 2.0 exports (`pub use` macro re-exports and `pub macro` (once implemented) at the crate root.
Configuration menu - View commit details
-
Copy full SHA for 8c16c45 - Browse repository at this point
Copy the full SHA 8c16c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 910532e - Browse repository at this point
Copy the full SHA 910532eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 449219a - Browse repository at this point
Copy the full SHA 449219aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 222ca3c - Browse repository at this point
Copy the full SHA 222ca3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95bd7f2 - Browse repository at this point
Copy the full SHA 95bd7f2View commit details
Commits on Mar 17, 2017
-
documented order of conversion between u32 an ipv4addr
z1mvader committedMar 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 50cede0 - Browse repository at this point
Copy the full SHA 50cede0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 963d4df - Browse repository at this point
Copy the full SHA 963d4dfView commit details -
This seems to match other uses of "be accessed" in the document.
Configuration menu - View commit details
-
Copy full SHA for ec8ecf4 - Browse repository at this point
Copy the full SHA ec8ecf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a5665 - Browse repository at this point
Copy the full SHA 33a5665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b7c4e - Browse repository at this point
Copy the full SHA 65b7c4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d38ea8b - Browse repository at this point
Copy the full SHA d38ea8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9511fe6 - Browse repository at this point
Copy the full SHA 9511fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10510ae - Browse repository at this point
Copy the full SHA 10510aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37b38a2 - Browse repository at this point
Copy the full SHA 37b38a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48890d4 - Browse repository at this point
Copy the full SHA 48890d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f4a1b - Browse repository at this point
Copy the full SHA a8f4a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1241a88 - Browse repository at this point
Copy the full SHA 1241a88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27fcdb8 - Browse repository at this point
Copy the full SHA 27fcdb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae630ca - Browse repository at this point
Copy the full SHA ae630caView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb96ade - Browse repository at this point
Copy the full SHA cb96adeView commit details
Commits on Mar 18, 2017
-
Fix a spelling error in HashMap documentation, and slightly reword it…
… to be more precise.
Configuration menu - View commit details
-
Copy full SHA for 2976ddb - Browse repository at this point
Copy the full SHA 2976ddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eaac08 - Browse repository at this point
Copy the full SHA 8eaac08View commit details -
Configuration menu - View commit details
-
Copy full SHA for e16d286 - Browse repository at this point
Copy the full SHA e16d286View commit details -
Rollup merge of rust-lang#40241 - Sawyer47:fix-39997, r=alexcrichton
Change how the `0` flag works in format! Now it always implies right-alignment, so that padding zeroes are placed after the sign (if any) and before the digits. In other words, it always takes precedence over explicitly specified `[[fill]align]`. This also affects the '#' flag: zeroes are placed after the prefix (0b, 0o, 0x) and before the digits. Here's a short summary of how similar format strings work in Python and Rust: ``` :05 :<05 :>05 :^05 Python 3.6 |-0001| |-1000| |000-1| |0-100| Rust before |-0001| |-1000| |-0001| |-0100| Rust after |-0001| |-0001| |-0001| |-0001| :#05x :<#05x :>#05x :^#05x Python 3.6 |0x001| |0x100| |000x1| |00x10| Rust before |0x001| |0x100| |000x1| |0x010| Rust after |0x001| |0x001| |0x001| |0x001| ``` Fixes rust-lang#39997 [breaking-change]
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for a6cb1ef - Browse repository at this point
Copy the full SHA a6cb1efView commit details -
Rollup merge of rust-lang#40346 - jseyfried:path_and_tokenstream_attr…
…, r=nrc `TokenStream`-based attributes, paths in attribute and derive macro invocations This PR - refactors `Attribute` to use `Path` and `TokenStream` instead of `MetaItem`. - supports macro invocation paths for attribute procedural macros. - e.g. `#[::foo::attr_macro] struct S;`, `#[cfg_attr(all(), foo::attr_macro)] struct S;` - supports macro invocation paths for derive procedural macros. - e.g. `#[derive(foo::Bar, super::Baz)] struct S;` - supports arbitrary tokens as arguments to attribute procedural macros. - e.g. `#[foo::attr_macro arbitrary + tokens] struct S;` - supports using arbitrary tokens in "inert attributes" with derive procedural macros. - e.g. `#[derive(Foo)] struct S(#[inert arbitrary + tokens] i32);` where `#[proc_macro_derive(Foo, attributes(inert))]` r? @nrc
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 67cc915 - Browse repository at this point
Copy the full SHA 67cc915View commit details -
Rollup merge of rust-lang#40348 - nrc:save-extern-fn, r=@eddyb
Handle extern functions and statics in save-analysis r? @eddyb
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 8e6afbf - Browse repository at this point
Copy the full SHA 8e6afbfView commit details -
Rollup merge of rust-lang#40377 - camlorn:optimization_fuel, r=arielb1
Implement optimization fuel and re-enable struct field reordering See [this discussion](https://internals.rust-lang.org/t/rolling-out-or-unrolling-struct-field-reorderings/4485) for background. This pull request adds two new compilation options: `-Z print-fuel=crate` prints the optimization fuel used by a crate and `-Z fuel=crate=n` sets the optimization fuel for a crate. It also turns field reordering back on. There is no way to test this feature without something consuming fuel. We can roll this back if we want, but then the optimization fuel bits will be dead code. The one notable absence from this PR is a test case. I'm not sure how to do one that's worth having. The only thing I can think of to test is `-Z fuel=foo=0`. The problem with other tests is that either (1) they're so big that future optimizations will apply, thus breaking them or (2) we don't know which order the optimizations will be applied in, so we can't guess the message that will be printed. If someone has a useful proposal for a good test, I certainly want to add one.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 74028ba - Browse repository at this point
Copy the full SHA 74028baView commit details -
Rollup merge of rust-lang#40398 - eddyb:struct-hint, r=nikomatsakis
Propagate expected type hints through struct literals. Partial fix for rust-lang#31260 to maximize backwards-compatibility, i.e. the hint is provided but not coerced to. The added test works because `{...; x}` with a hint of `T` coerces `x` to `T`, and the reasoning why that is slightly different has to do with DSTs: `&Struct { tail: [x] }: &Struct<[T]>` has a hint of `[T]` for `[x]`, but the inferred type should be `[T; 1]` to succeed later, so `[x]` shouldn't be *forced* to be `[T]`. *However*, implementing that complete behavior in a backwards-compatible way may be non-trivial, and has not yet been fully investigated, while this PR fixes rust-lang#40355 and can be backported. r? @nikomatsakis
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 834e2e8 - Browse repository at this point
Copy the full SHA 834e2e8View commit details -
Rollup merge of rust-lang#40409 - mbrubeck:calloc, r=sfackler
Specialize Vec::from_elem to use calloc Fixes rust-lang#38723. This specializes the implementation for `u8` only, but it could be extended to other zeroable types if desired. I haven't tested this extensively, but I did verify that it gives the expected performance boost for large `vec![0; n]` allocations with both alloc_system and jemalloc, on Linux. (I have not tested or even built the Windows code.)
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for f340b0b - Browse repository at this point
Copy the full SHA f340b0bView commit details -
Rollup merge of rust-lang#40441 - tschottdorf:promotable-rfc, r=eddyb
Add feature gate for rvalue-static-promotion Probably needs more tests (which ones?) and there may be other things that need to be done. Also not sure whether the version that introduces the flag is really `1.15.1`. See rust-lang/rfcs#1414. Updates rust-lang#38865.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for d050aee - Browse repository at this point
Copy the full SHA d050aeeView commit details -
Rollup merge of rust-lang#40445 - estebank:issue-18150, r=jonathandtu…
…rner Point to let when modifying field of immutable variable Point at the immutable local variable when trying to modify one of its fields. Given a file: ```rust struct Foo { pub v: Vec<String> } fn main() { let f = Foo { v: Vec::new() }; f.v.push("cat".to_string()); } ``` present the following output: ``` error: cannot borrow immutable field `f.v` as mutable --> file.rs:7:13 | 6 | let f = Foo { v: Vec::new() }; | - this should be `mut` 7 | f.v.push("cat".to_string()); | ^^^ error: aborting due to previous error ``` Fix rust-lang#27593.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 6a6d6de - Browse repository at this point
Copy the full SHA 6a6d6deView commit details -
Rollup merge of rust-lang#40509 - jseyfried:duplicate_check_macro_exp…
…orts, r=nrc Forbid conflicts between macros 1.0 exports and macros 2.0 exports This PR forbids for conflicts between `#[macro_export]`/`#[macro_reexport]` macro exports and `pub use` macro exports. For example, ```rust // crate A: pub use macros::foo; //^ This is allowed today, will be forbidden by this PR. // crate B: extern crate A; // This triggers a confusing error today. use A::foo; // This could refer to refer to either macro export in crate A. ``` r? @nrc
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for bed891d - Browse repository at this point
Copy the full SHA bed891dView commit details -
Rollup merge of rust-lang#40521 - TimNN:panic-free-shift, r=alexcrichton
Implemente overflowing_sh* with new unchecked_sh* intrinsics Also update some 128 bit builtins to not rely on the constant evaluator to avoid checked operations. Fixes rust-lang#40508. cc @nagisa, @alexcrichton Note: I still have a build running to see if the 128 bit changes worked (unoptimized builds take *forever* to compile), however at least the overflowing builtins no longer reference `core::panicking::panic`.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 7474930 - Browse repository at this point
Copy the full SHA 7474930View commit details -
Rollup merge of rust-lang#40523 - durka:patch-38, r=petrochenkov
add test for nested macro def (rust-lang#31946) Adds a test for issue rust-lang#31946 which was fixed in 1.12.0. Closes rust-lang#31946.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for ca26c79 - Browse repository at this point
Copy the full SHA ca26c79View commit details -
Rollup merge of rust-lang#40532 - jseyfried:improve_tokenstream_quote…
…r, r=nrc macros: improve the `TokenStream` quoter This PR - renames the `TokenStream` quoter from `qquote!` to `quote!`, - uses `$` instead of `unquote` (e.g. `let toks: TokenStream = ...; quote!([$toks])`), - allows unquoting `Token`s as well as `TokenTree`s and `TokenStream`s (fixes rust-lang#39746), and - to preserve syntactic space, requires that `$` be followed by - a single identifier to unquote, or - another `$` to produce a literal `$`. r? @nrc
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 663409b - Browse repository at this point
Copy the full SHA 663409bView commit details -
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
Library stabilizations for 1.17 Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17. Will need a beta backport, which I will create after approval. r? @alexcrichton
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for c2e6d72 - Browse repository at this point
Copy the full SHA c2e6d72View commit details -
Rollup merge of rust-lang#40564 - GuillaumeGomez:rustdoc-const, r=fre…
…wsxcv Fix const not displayed in rustdoc Fixes rust-lang#40331. r? @rust-lang/docs
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 196011c - Browse repository at this point
Copy the full SHA 196011cView commit details -
Rollup merge of rust-lang#40581 - TimNN:di-global-40, r=alexcrichton
[LLVM 4.0] Add missing debuginfo metadata to globals Fixes rust-lang#40580. cc @rkruppe cc rust-lang#40123
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 3c912fb - Browse repository at this point
Copy the full SHA 3c912fbView commit details -
Rollup merge of rust-lang#40583 - jseyfried:fix_include_macro_regress…
…ion, r=nrc macros: fix regression with `include!()` Fixes rust-lang#40469, a regression when `include!()`ing a `macro_rules!` containing `$crate`. r? @nrc
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 76c9d17 - Browse repository at this point
Copy the full SHA 76c9d17View commit details -
Rollup merge of rust-lang#40588 - topecongiro:add-missing-tests, r=al…
…excrichton Add a test for issue 34571 Closes rust-lang#34571.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 664d9a5 - Browse repository at this point
Copy the full SHA 664d9a5View commit details -
Rollup merge of rust-lang#40589 - topecongiro:floating-point-literal,…
… r=nagisa Parse 0e+10 as a valid floating-point literal Fixes issue rust-lang#40408.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for d3d2866 - Browse repository at this point
Copy the full SHA d3d2866View commit details -
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
documented order of conversion between u32 an ipv4addr This fixes rust-lang#40118
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for a8b619c - Browse repository at this point
Copy the full SHA a8b619cView commit details -
Rollup merge of rust-lang#40603 - QuietMisdreavus:slice-ptr-docs, r=G…
…uillaumeGomez minor wording tweak to slice::{as_ptr, as_mut_ptr} Per rust-lang#37334, the slice-as-pointer methods mentioned that "modifying the slice may cause its buffer to be reallocated", when in fact modifying the *slice* itself would cause no such change. (It is a borrow, after all!) This is a tweak to the wording of that line to stress it's the *collection* that could cause the buffer to be reallocated. r? @steveklabnik
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 42ead56 - Browse repository at this point
Copy the full SHA 42ead56View commit details -
Rollup merge of rust-lang#40611 - ScottAbbey:patch-1, r=GuillaumeGomez
Fix typo in mutex.rs docs This seems to match other uses of "be accessed" in the document.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 144c9e6 - Browse repository at this point
Copy the full SHA 144c9e6View commit details -
Rollup merge of rust-lang#40621 - jswalden:dependant-spelling-fix, r=…
…sfackler Fix a spelling error in HashMap documentation, and slightly reword surrounding text for precision Noticed while reading docs just now. It's possible that the prior wording *meant* to state that the seed's randomness depends on the exact instant that the system RNG was created, I guess. But unless there's an API guarantee that this is the case, the wording seems over-precise. Is there a formal API guarantee that would forbid, say, the system RNG from generating all output using the Intel RDRAND instruction? I don't think the quality of output in that case would depend on when the RNG was created. Yet it seems to me like it could well be a valid source of randomness when computing the initial seed. For that reason, tying the randomness of the seed, to the quality of the RNG's output *at the precise instant the seed is computed*, seems less confining. That instantaneous quality level could be determined by the quality at the instant the RNG was created -- but instantaneous quality need not be low for that precise reason.
Ariel Ben-Yehuda committedMar 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 337cbc1 - Browse repository at this point
Copy the full SHA 337cbc1View commit details