Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mdbook dep to pick up new 'create missing' toggle feature. #41572

Merged
merged 1 commit into from Apr 28, 2017

Conversation

frewsxcv
Copy link
Member

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

r? @steveklabnik

@frewsxcv frewsxcv added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Apr 27, 2017
@frewsxcv
Copy link
Member Author

Hold off on r+'ing this, I want to confirm this is working as intended.

@frewsxcv
Copy link
Member Author

Blocked on https://github.com/azerupi/mdBook/pull/259.

@steveklabnik
Copy link
Member

@frewsxcv looks like that was merged and published

@frewsxcv
Copy link
Member Author

frewsxcv commented Apr 27, 2017

cool, everything is working.

[00:36:22] An error occured:
[00:36:22] '/checkout/src/doc/unstable-book/src/foo.md' referenced from SUMMARY.md does not exist.
[00:36:22] 
[00:36:22] 
[00:36:22] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/rustbook" "build" "/checkout/src/doc/unstable-book" "-d" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc/unstable-book"
[00:36:22] expected success, got: exit code: 101
[00:36:22] 
[00:36:22] 
[00:36:22] Build completed unsuccessfully in 0:02:22
[00:36:22] make: *** [all] Error 1
[00:36:22] Makefile:24: recipe for target 'all' failed

@steveklabnik this is ready for review now

@frewsxcv
Copy link
Member Author

Looks like the build was cancelled on Travis, but this should be still good to go.

@steveklabnik
Copy link
Member

This looks good; I've restarted the build. r=me once travis passes.

@frewsxcv
Copy link
Member Author

@bors r=steveklabnik

@bors
Copy link
Contributor

bors commented Apr 27, 2017

📌 Commit a517a96 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 27, 2017
Bump mdbook dep to pick up new 'create missing' toggle feature.

This will avoid obscure Travis CI error messages:

* rust-lang#40290 (comment)

Original mdbook issue:

* https://github.com/azerupi/mdBook/issues/253

mdbook PR:

* https://github.com/azerupi/mdBook/pull/254
bors added a commit that referenced this pull request Apr 28, 2017
Rollup of 7 pull requests

- Successful merges: #41438, #41523, #41526, #41546, #41556, #41572, #41578
- Failed merges:
@bors bors merged commit a517a96 into rust-lang:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants