Add test for issue #16994. #41632
Merged
Add test for issue #16994. #41632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ rollup |
|
📌 Commit efe8872 has been approved by |
|
⌛ Testing commit efe8872 with merge 7a0814c... |
|
💔 Test failed - status-travis |
Mark-Simulacrum
force-pushed
the
test-16994
branch
from
efe8872
to
9bc53c8
Compare
|
r? @arielb1, I forgot the |
|
@bors r+ rollup |
|
📌 Commit 9bc53c8 has been approved by |
|
⌛ Testing commit 9bc53c8 with merge 510d89c... |
|
💔 Test failed - status-travis |
Mark-Simulacrum
force-pushed
the
test-16994
branch
from
9bc53c8
to
3b00323
Compare
|
I should really stop trying to guess at the correct fix. This time tests passed locally. I'd wait for Travis though. |
|
@bors r+ rollup |
|
📌 Commit 3b00323 has been approved by |
carols10cents
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16994.
Please check that this is the correct way to write this test.
r? @arielb1 (author of test case)