Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: fix layout of Fields section in documentation for unions #43436

Merged
merged 1 commit into from Jul 24, 2017

Conversation

zackmdavis
Copy link
Member

Previously, the union fields would all render on the same line with
hideous spacing; comparison to the analogous section for structs makes
it undoubtable that display: block is the true intent.

Concisely and definitively resolves #43404 and its perfidious
malignancy.

Previously, the union fields would all render on the same line with
hideous spacing; comparison to the analogous section for structs makes
it undoubtable that `display: block` is the true intent.

Concisely and definitively resolves rust-lang#43404 and its perfidious
malignancy.
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 24, 2017

📌 Commit 0fdb502 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jul 24, 2017

⌛ Testing commit 0fdb502 with merge 5669c99...

bors added a commit that referenced this pull request Jul 24, 2017
…GuillaumeGomez

rustdoc: fix layout of Fields section in documentation for unions

Previously, the union fields would all render on the same line with
hideous spacing; comparison to the analogous section for structs makes
it undoubtable that `display: block` is the true intent.

Concisely and definitively resolves #43404 and its perfidious
malignancy.
@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 24, 2017
@bors
Copy link
Contributor

bors commented Jul 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 5669c99 to master...

@bors bors merged commit 0fdb502 into rust-lang:master Jul 24, 2017
@zackmdavis zackmdavis deleted the union_doc_fields_section_layout branch January 13, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields section of union documentation is formatted weirdly in rustdoc
6 participants