Enable building clippy in CI #45177
Merged
Enable building clippy in CI #45177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ 👍 |
|
📌 Commit 8e900aa has been approved by |
|
We should also ask folks to ping you/me/llogiq for clippy and you/scott for miri in the document? That way we can keep an eye out and help. |
MaloJaffre
reviewed
Oct 10, 2017
src/tools/toolstate.toml
Outdated
| @@ -26,7 +26,7 @@ | |||
| miri = "Broken" | |||
|
|
|||
| # ping @Manishearth @llogiq @mcarton @oli-obk | |||
| clippy = "Broken" | |||
| clippy = "Building" | |||
There was a problem hiding this comment.
This seems to break CI:
[00:02:42] failed to parse TOML configuration 'toolstate.toml': unknown variant `Building`, expected one of `Compiling`, `Testing`, `Broken` for key `clippy`
[00:02:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build nonexistent/path/to/trigger/cargo/metadata
[00:02:42] Build completed unsuccessfully in 0:01:16
[00:02:42] Makefile:79: recipe for target 'prepare' failed
[00:02:42] make: *** [prepare] Error 1
[00:02:42] Command failed. Attempt 2/5:
[00:02:42] Finished dev [unoptimized] target(s) in 0.0 secs
There was a problem hiding this comment.
Darn it... last minute changes are never a good idea... sorry about that. I also fixed the wrong docs on the top of the file
|
@Manishearth the pinging is already suggested in toolstate.toml |
|
@bors: r+ |
|
📌 Commit c6c47fa has been approved by |
aidanhs
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 14, 2017
Enable building clippy in CI r? @alexcrichton As discussed at Rustfest. Measured additional time is 4 minutes on my machine if no dependencies are shared with other tools. In reality most dependencies are shared (especially the slow to compile ones like serde). cc @Manishearth Does not run clippy's test suite, since a) it is nontrivial in the rustc build system b) it breaks more frequently but the breakage is negligible If clippy breaks, the procedure to follow is documented under https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#external-dependencies
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton
As discussed at Rustfest. Measured additional time is 4 minutes on my machine if no dependencies are shared with other tools. In reality most dependencies are shared (especially the slow to compile ones like serde).
cc @Manishearth
Does not run clippy's test suite, since
a) it is nontrivial in the rustc build system
b) it breaks more frequently but the breakage is negligible
If clippy breaks, the procedure to follow is documented under https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#external-dependencies