Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport ThinLTO LLVM 5 fixes #45301

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Backport ThinLTO LLVM 5 fixes #45301

merged 2 commits into from
Oct 19, 2017

Conversation

ishitatsuyuki
Copy link
Contributor

This makes building nightly more convenient on Arch.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2017
@michaelwoerister
Copy link
Member

cc @alexcrichton

@alexcrichton
Copy link
Member

I believe this is no longer quite right with changes on the master branch, which also handle alias summaries. That will also need to be updated for LLVM 5

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2017
@ishitatsuyuki
Copy link
Contributor Author

r? @alexcrichton

Rebased. I hope this is correct.

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Oct 17, 2017
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2017
alexcrichton
alexcrichton reviewed Oct 17, 2017
View reviewed changes
src/rustllvm/PassWrapper.cpp Outdated
addPreservedGUID(Index, Preserved, GUID);
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is still missing handling of AliasSummary

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2017
@ishitatsuyuki
Copy link
Contributor Author

r? @alexcrichton

Added some auto, I think it's fine.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 19, 2017

📌 Commit 3efa003 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2017
bors added a commit that referenced this pull request Oct 19, 2017
@bors
Auto merge of #45301 - ishitatsuyuki:llvm5-backport, r=alexcrichton
8b45c24 
Backport ThinLTO LLVM 5 fixes

This makes building nightly more convenient on Arch.
@bors
Copy link
Contributor

bors commented Oct 19, 2017

⌛ Testing commit 3efa003 with merge 8b45c24...

@bors
Copy link
Contributor

bors commented Oct 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8b45c24 to master...

@bors bors merged commit 3efa003 into rust-lang:master Oct 19, 2017
@ishitatsuyuki ishitatsuyuki deleted the llvm5-backport branch July 15, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ishitatsuyuki @rust-highfive @michaelwoerister @alexcrichton @bors @kennytm @aturon