rustc: Add _imp_ symbols later in compilation

[alexcrichton]

On MSVC targets rustc will add symbols prefixed with _imp_ to LLVM modules to
"emulate" dllexported statics as that workaround is still in place after #27438
hasn't been solved otherwise. These statics, however, were getting gc'd by
ThinLTO accidentally which later would cause linking failures.

This commit updates the location we add such symbols to happen just before
codegen to ensure that (a) they're not eliminated by the optimizer and (b) the
optimizer doesn't even worry about them.

Closes #45347

[rust-highfive]

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

r? @michaelwoerister

[michaelwoerister]

Thanks, @alexcrichton!

r=me with the comment in the test case added.

[michaelwoerister]

Could you add a comment what this is all about? Otherwise one might be a little lost when this test fails.

[alexcrichton]

@bors: r=michaelwoerister

[bors]

📌 Commit 3541ffb has been approved by michaelwoerister

[bors]

⌛ Testing commit 3541ffb with merge 0e612b6c44ca77fa77c60680ebf0f8a498902dee...

[bors]

💔 Test failed - status-appveyor

[kennytm]

The test against xsv failed on check-aux x86_64-pc-windows-msvc

[01:08:09] failures:
[01:08:09] 
[01:08:09] ---- test_frequency::prop_frequency stdout ----
[01:08:09] 	[C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-821]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
[01:08:09] [C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-823]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
...
[01:08:09] [C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-957]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
[01:08:09] thread 'test_frequency::prop_frequency' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (CsvData { data: [[[239, 187, 191]], [[]]] })
[01:08:09] Error: "called `Option::unwrap()` on a `None` value"', C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\quickcheck-0.4.1\src\tester.rs:147:27
[01:08:09] 
[01:08:09] 
[01:08:09] failures:
[01:08:09]     test_frequency::prop_frequency
[01:08:09] 
[01:08:09] test result: FAILED. 420 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:08:09] 
[01:08:09] error: test failed, to rerun pass '--test tests'

[alexcrichton]

wut

[alexcrichton]

That test failure is a quickcheck-based test, and otherwise this PR should only affect linkage (not runtime), so I'm going to retry assuming it's spurious. If this lands I'll open an issue upstream.

@bors: retry

[bors]

⌛ Testing commit 3541ffb with merge 6511b4f...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 6511b4f to master...