Add missing links and examples #45582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like you have some broken links |
kennytm
added
the
S-waiting-on-author
|
Indeed. I'll fix this as soon as I can. |
ollie27
reviewed
Oct 29, 2017
| /// let file_type = meta.file_type(); | ||
| /// assert!(file_type.is_block_device()); | ||
| /// # Ok(()) | ||
| /// # } |
There was a problem hiding this comment.
Missing closing ``` for all of these examples.
GuillaumeGomez
force-pushed
the
doc-unix-missing-links
branch
from
6ca517d
to
6c55050
Compare
|
Added missing |
kennytm
reviewed
Nov 2, 2017
src/libstd/sys/unix/ext/fs.rs
Outdated
| /// Unix-specific extensions to `File` | ||
| /// Unix-specific extensions to [`File`]. | ||
| /// | ||
| /// [`File`]: ../../../std/fs/struct.File.html |
There was a problem hiding this comment.
There are still broken links (not enough ../)
[01:12:39] std/os/unix/fs/trait.DirEntryExt.html:54: broken link - std/std/fs/struct.DirEntry.html
[01:12:39] std/os/unix/fs/index.html:59: broken link - std/std/fs/struct.DirBuilder.html
[01:12:39] std/os/unix/fs/index.html:66: broken link - std/std/fs/struct.DirEntry.html
[01:12:39] std/os/unix/fs/index.html:73: broken link - std/std/fs/struct.File.html
[01:12:39] std/os/unix/fs/trait.FileExt.html:55: broken link - std/std/fs/struct.File.html
[01:12:39] std/os/unix/fs/trait.DirBuilderExt.html:54: broken link - std/std/fs/struct.DirBuilder.html
There was a problem hiding this comment.
Forgot a .. once again...
GuillaumeGomez
force-pushed
the
doc-unix-missing-links
branch
from
6c55050
to
b678e59
Compare
|
Fixed. |
kennytm
added
S-waiting-on-review
src/libstd/sys/unix/ext/fs.rs
Outdated
| /// | ||
| /// ``` | ||
| /// use std::fs; | ||
| /// use std::os::unix::prelude::FileTypeExt; |
There was a problem hiding this comment.
Can you import the trait from std::os::unix::fs::FileTypeExt instead?
There was a problem hiding this comment.
same goes for the other imports in these examples
frewsxcv
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
r=me with @QuietMisdreavus's comment (and maybe mine) addressed. nice work! ✨
src/libstd/sys/unix/ext/fs.rs
Outdated
| @@ -269,19 +271,79 @@ impl MetadataExt for fs::Metadata { | |||
| fn blocks(&self) -> u64 { self.st_blocks() } | |||
| } | |||
|
|
|||
| /// Add special unix types (block/char device, fifo and socket) | |||
| /// Add special unix types (block/char device, fifo and socket). | |||
There was a problem hiding this comment.
onder if this might be better worded as:
/// Add support for special unix types (block/char device, fifo and socket).
src/libstd/sys/unix/ext/fs.rs
Outdated
| /// | ||
| /// ``` | ||
| /// use std::fs; | ||
| /// use std::os::unix::prelude::FileTypeExt; |
There was a problem hiding this comment.
same goes for the other imports in these examples
kennytm
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
doc-unix-missing-links
branch
from
b678e59
to
cef0573
Compare
|
@bors: r=frewsxcv rollup |
|
📌 Commit cef0573 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2017
…ks, r=frewsxcv Add missing links and examples r? @rust-lang/docs
kennytm
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rust-lang/docs