in which suggestions to borrow casts or binary expressions are rectified #46761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple patch resolves rust-lang#46756 (which was specifically about the case of casts, but it would be poor form indeed to fix a reported issue without at least a cursory attempt at answering the immortal question, "How does this bug generalize?").
|
@bors r+ rollup |
|
📌 Commit 73a9019 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
zackmdavis
deleted the
concerning_incorrect_suggestions_for_referencing_a_cast
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #46756
r? @estebank