Use DefIndex encoding that works better with on-disk variable length integer representations. #47181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me with the build fixed There's a neat extension of this: you could interleave various categories of |
michaelwoerister
force-pushed
the
var-len-def-index
branch
from
00d3e88 to
7294e90
Compare
|
@michaelwoerister looks like travis may still have a panic? |
|
Yes, that's something different though. I'll investigate. |
alexcrichton
added
the
S-waiting-on-author
…ble length integer encodings.
michaelwoerister
force-pushed
the
var-len-def-index
branch
from
7294e90 to
c9d25e3
Compare
|
Build fixed. @bors r=eddyb |
|
📌 Commit c9d25e3 has been approved by |
michaelwoerister
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 9, 2018
Use DefIndex encoding that works better with on-disk variable length integer representations. Use the least instead of the most significant bit for representing the address space. r? @eddyb
|
💔 Test failed - status-appveyor |
|
@bors retry (looks like a timeout on appveyor) |
bors
added a commit
that referenced
this pull request
Jan 10, 2018
Use DefIndex encoding that works better with on-disk variable length integer representations. Use the least instead of the most significant bit for representing the address space. r? @eddyb
|
💔 Test failed - status-appveyor |
|
⌛ Testing commit c9d25e3 with merge 7c6a159da3c32bcb06f13c00f8019df29037282b... |
|
💔 Test failed - status-appveyor |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 11, 2018
Use DefIndex encoding that works better with on-disk variable length integer representations. Use the least instead of the most significant bit for representing the address space. r? @eddyb
|
@bors retry |
bors
added a commit
that referenced
this pull request
Jan 13, 2018
Use DefIndex encoding that works better with on-disk variable length integer representations. Use the least instead of the most significant bit for representing the address space. r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the least instead of the most significant bit for representing the address space.
r? @eddyb