Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples of Duration::subsec_millis and Duration::subsec_micros #47375

Merged
merged 1 commit into from Jan 12, 2018
Merged

Fix examples of Duration::subsec_millis and Duration::subsec_micros #47375

merged 1 commit into from Jan 12, 2018

Conversation

overvenus
Copy link
Contributor

Update examples of Duration::subsec_millis and Duration::subsec_micros, because they are not for these two methods actually.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

dtolnay
dtolnay approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jan 12, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 12, 2018

📌 Commit 7cad7f6 has been approved by dtolnay

@kennytm kennytm mentioned this pull request Jan 12, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 12, 2018
@kennytm
Rollup merge of rust-lang#47375 - overvenus:duration-examples, r=dtolnay
21ac84e 
Fix examples of Duration::subsec_millis and Duration::subsec_micros

Update examples of `Duration::subsec_millis` and `Duration::subsec_micros`, because they are not for these two methods actually.
bors added a commit that referenced this pull request Jan 12, 2018
@bors
Auto merge of #47392 - kennytm:rollup, r=kennytm
51b0b37 
Rollup of 24 pull requests

- Successful merges: #46985, #47069, #47081, #47185, #47282, #47283, #47288, #47289, #47298, #47305, #47306, #47307, #47310, #47324, #47328, #47331, #47340, #47343, #47344, #47352, #47357, #47365, #47375, #47382
- Failed merges: #47334
@bors bors merged commit 7cad7f6 into rust-lang:master Jan 12, 2018
@overvenus overvenus deleted the duration-examples branch January 13, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@overvenus @rust-highfive @dtolnay @bors