Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Turn back on "fat" LTO by default #47548

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

alexcrichton
Copy link
Member

This commit reverts a small portion of the switch to ThinLTO by default which
changed the meaning of -C lto from "put the whole crate graph into one codegen
unit" to "perform ThinLTO over the whole crate graph". This backport has no
corresponding commit on master as #47521 is making the same change but in a
slightly different manner. This commit is intended to be a surgical change with
low impact on beta.

Closes #47409

This commit reverts a small portion of the switch to ThinLTO by default which
changed the meaning of `-C lto` from "put the whole crate graph into one codegen
unit" to "perform ThinLTO over the whole crate graph". This backport has no
corresponding commit on master as rust-lang#47521 is making the same change but in a
slightly different manner. This commit is intended to be a surgical change with
low impact on beta.

Closes rust-lang#47409
@alexcrichton
Copy link
Member Author

r? @michaelwoerister

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2018
@michaelwoerister
Copy link
Member

Thanks, @alexcrichton!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2018

📌 Commit c4771ec has been approved by michaelwoerister

@MaloJaffre
Copy link
Contributor

MaloJaffre commented Jan 21, 2018

Does this PR need a higher bors priority because it is a beta-backport?

@Mark-Simulacrum
Copy link
Member

@bors p=1

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2018
@bors
Copy link
Contributor

bors commented Jan 21, 2018

⌛ Testing commit c4771ec with merge c7037ff...

bors added a commit that referenced this pull request Jan 21, 2018
[beta] Turn back on "fat" LTO by default

This commit reverts a small portion of the switch to ThinLTO by default which
changed the meaning of `-C lto` from "put the whole crate graph into one codegen
unit" to "perform ThinLTO over the whole crate graph". This backport has no
corresponding commit on master as #47521 is making the same change but in a
slightly different manner. This commit is intended to be a surgical change with
low impact on beta.

Closes #47409
@bors
Copy link
Contributor

bors commented Jan 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing c7037ff to beta...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants