Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result box error tests #47601

Closed
wants to merge 5 commits into from
Closed

Result box error tests #47601

wants to merge 5 commits into from

Conversation

U007D
Copy link

@U007D U007D commented Jan 19, 2018

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@cramertj
Copy link
Member

@U007D Is there a reason this is in a separate PR from #47544 ?

@U007D
Copy link
Author

U007D commented Jan 19, 2018

Yes, because I messed something up? ;) Seriously, no, it's supposed to be integrated with the other PR. Let me look into what I button I fat-fingered...

(I figured out what happened. Github defaults to merging back to the rust-lang/master branch instead of my local fork's master, and I missed that. Sorry for the noise!)

@U007D U007D closed this Jan 19, 2018
@cramertj
Copy link
Member

No problem!

@U007D U007D deleted the result_box_error_tests branch January 22, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants