Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering issues on mobile #47810

Merged
merged 3 commits into from Feb 7, 2018

Conversation

GuillaumeGomez
Copy link
Member

@QuietMisdreavus
Copy link
Member

This keeps the button from moving into the sidebar menu when it's expanded, but it doesn't help the crate version from sitting underneath it:

image

@kennytm kennytm added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2018
@GuillaumeGomez
Copy link
Member Author

Updated.

@QuietMisdreavus
Copy link
Member

QuietMisdreavus commented Feb 3, 2018

Now we've gone back to the button being awkward when the menu's open:

image

image

(these screenshots taken with firefox's responsive design mode, but it does the same thing in mobile safari on my phone)

@GuillaumeGomez
Copy link
Member Author

I fixed a few others things as well. (Got too much motivation)

@QuietMisdreavus
Copy link
Member

We're down to a couple small things that aren't deal-breakers. Let's merge this.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 6, 2018

📌 Commit 8a587e6 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2018
@QuietMisdreavus
Copy link
Member

The things i've found. I'll post an issue once this is merged.

The padding on the top bar seems to be rendered in a different color? It's really subtle in the dark theme, but in the light theme it sticks out. Strangely, when viewing this in Chrome, the color resets to the "proper" one when i start mousing over elements in the inspector (which causes them to be highlighted in the page), so this may be a Chrome thing.

image

I like how the theme button is next to the search box now, but i guess i expected it to disappear under the menu when it's open? Right now it's just hovering awkwardly over the search box.

image

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 7, 2018
…on, r=QuietMisdreavus

Fix rendering issues on mobile

Fixes rust-lang#47723

r? @QuietMisdreavus
bors added a commit that referenced this pull request Feb 7, 2018
Rollup of 10 pull requests

- Successful merges: #47613, #47631, #47810, #47883, #47922, #47944, #48014, #48018, #48020, #48028
- Failed merges:
@bors bors merged commit 8a587e6 into rust-lang:master Feb 7, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-theme-but-position branch February 7, 2018 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants