Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround abort(2) on compilation error on FreeBSD. #48494

Merged
merged 1 commit into from Feb 25, 2018

Conversation

bdrewery
Copy link
Contributor

@bdrewery bdrewery commented Feb 24, 2018

Same problem as OpenBSD, tracking bug #43575.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2018
@eddyb
Copy link
Member

eddyb commented Feb 24, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Feb 24, 2018

📌 Commit 34b45c1 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 25, 2018
…, r=eddyb

Workaround abort(2) on compilation error on FreeBSD.

Same problem as OpenBSD, tracking bug rust-lang#43575.

@semarie @dumbbell
bors added a commit that referenced this pull request Feb 25, 2018
Rollup of 17 pull requests

- Successful merges: #47964, #47970, #48076, #48115, #48166, #48281, #48297, #48302, #48362, #48369, #48489, #48491, #48494, #48517, #48529, #48235, #48330
- Failed merges:
@bors bors merged commit 34b45c1 into rust-lang:master Feb 25, 2018
bdrewery added a commit to bdrewery/rust that referenced this pull request Mar 14, 2018
Same problem as OpenBSD, tracking bug rust-lang#43575.

Backport from rust-lang#48494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants