Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the Termination impls to simplify stabilization #48497

Merged
merged 1 commit into from
Feb 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/libstd/process.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,15 @@ impl fmt::Display for ExitStatus {
}
}

/// This is ridiculously unstable, as it's a completely-punted-upon part
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care, but I feel like this is overstating the case. Specifying an exit code doesn't seem so "wild and crazy" to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what I meant, but I can see what you mean after rereading. I'll make a follow-up PR weakening the language here.

I definitely agree that fn main() -> ExitCode is valuable. I only intended the statement to be about the precise form of this type, since it's not B-RFC-Approved and thus even more subject to change than usual.

/// of the `?`-in-`main` RFC. It's here only to allow experimenting with
/// returning a code directly from main. It will definitely change
/// drastically before being stabilized, if it doesn't just get deleted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Maybe we should #[doc(hidden)] it?

#[doc(hidden)]
#[derive(Clone, Copy, Debug)]
#[unstable(feature = "process_exitcode_placeholder", issue = "43301")]
pub struct ExitCode(pub i32);

impl Child {
/// Forces the child to exit. This is equivalent to sending a
/// SIGKILL on unix platforms.
Expand Down Expand Up @@ -1428,7 +1437,7 @@ impl Termination for () {
}

#[unstable(feature = "termination_trait_lib", issue = "43301")]
impl<T: Termination, E: fmt::Debug> Termination for Result<T, E> {
impl<E: fmt::Debug> Termination for Result<(), E> {
fn report(self) -> i32 {
match self {
Ok(val) => val.report(),
Expand All @@ -1442,20 +1451,23 @@ impl<T: Termination, E: fmt::Debug> Termination for Result<T, E> {

#[unstable(feature = "termination_trait_lib", issue = "43301")]
impl Termination for ! {
fn report(self) -> i32 { unreachable!(); }
fn report(self) -> i32 { self }
}

#[unstable(feature = "termination_trait_lib", issue = "43301")]
impl Termination for bool {
impl<E: fmt::Debug> Termination for Result<!, E> {
fn report(self) -> i32 {
if self { exit::SUCCESS } else { exit::FAILURE }
let Err(err) = self;
eprintln!("Error: {:?}", err);
exit::FAILURE
}
}

#[unstable(feature = "termination_trait_lib", issue = "43301")]
impl Termination for i32 {
impl Termination for ExitCode {
fn report(self) -> i32 {
self
let ExitCode(code) = self;
code
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
// except according to those terms.

#![feature(termination_trait)]
#![feature(process_exitcode_placeholder)]

fn main() -> i32 {
0
use std::process::ExitCode;

fn main() -> ExitCode {
ExitCode(0)
}