Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Start a custom cabi module for wasm32 #48959

Merged
merged 1 commit into from
Mar 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/librustc_trans/abi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ use cabi_sparc64;
use cabi_nvptx;
use cabi_nvptx64;
use cabi_hexagon;
use cabi_wasm32;
use mir::place::PlaceRef;
use mir::operand::OperandValue;
use type_::Type;
Expand Down Expand Up @@ -948,7 +949,13 @@ impl<'a, 'tcx> FnType<'tcx> {
"powerpc64" => cabi_powerpc64::compute_abi_info(cx, self),
"s390x" => cabi_s390x::compute_abi_info(cx, self),
"asmjs" => cabi_asmjs::compute_abi_info(cx, self),
"wasm32" => cabi_asmjs::compute_abi_info(cx, self),
"wasm32" => {
if cx.sess().opts.target_triple.contains("emscripten") {
cabi_asmjs::compute_abi_info(cx, self)
} else {
cabi_wasm32::compute_abi_info(cx, self)
}
}
"msp430" => cabi_msp430::compute_abi_info(self),
"sparc" => cabi_sparc::compute_abi_info(cx, self),
"sparc64" => cabi_sparc64::compute_abi_info(cx, self),
Expand Down
31 changes: 31 additions & 0 deletions src/librustc_trans/cabi_wasm32.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

use abi::{FnType, ArgType};
use context::CodegenCx;

fn classify_ret_ty<'a, 'tcx>(_cx: &CodegenCx<'a, 'tcx>, ret: &mut ArgType<'tcx>) {
ret.extend_integer_width_to(32);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't do the aggregate to indirect conversion anymore that the asm.js C ABI did: https://github.com/alexcrichton/rust/blob/74f5dd07cff8dba348f91cfef4df5242ab33a311/src/librustc_trans/cabi_asmjs.rs#L20-L33

However looking at how the C ABI for wasm is implemented in clang, it seems to still do it: https://github.com/llvm-mirror/clang/blob/master/lib/CodeGen/TargetInfo.cpp#L759-L775

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah TBH I have very little clue what ABI-related code is doing...

Seems fine though for us to match clang! Until there's an "official ABI" though this'll probably be a game of cat and mouse.

Copy link
Contributor

@CryZe CryZe Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Seems fine though for us to match clang!"
I'm a bit confused by that wording. What I'm saying is that we don't match clang anymore with this PR, so shouldn't we include the aggregate code as well to properly match it again?

It seems to be the same as the asm.js one, so we can just copy the code from there / call it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er sorry, what I mean is that it seems fine to add. It won't have any effect today anyway as you can't intermingle wasm32-unknown-unknown and C yet so I'm hoping that we can fix this with a test in the future. (I'm also hesitant to add things that I don't personally understand in my own PRs)

Copy link
Contributor

@CryZe CryZe Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it also affects everyone who is calling an exported function from JS / a wasm environment. However I guess we don't really give any guarantees how structs are represented there anyway, so I guess it's fine to wait on the C ABI settling.

Maybe we should open an issue about this though? Otherwise we might forget about this disparity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah with a lack of a spec about an ABI returning any sort of aggregate or non-integer/float is sort of "best effort" today anyway


fn classify_arg_ty(arg: &mut ArgType) {
arg.extend_integer_width_to(32);
}

pub fn compute_abi_info<'a, 'tcx>(cx: &CodegenCx<'a, 'tcx>, fty: &mut FnType<'tcx>) {
if !fty.ret.is_ignore() {
classify_ret_ty(cx, &mut fty.ret);
}

for arg in &mut fty.args {
if arg.is_ignore() { continue; }
classify_arg_ty(arg);
}
}
1 change: 1 addition & 0 deletions src/librustc_trans/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ mod cabi_sparc64;
mod cabi_x86;
mod cabi_x86_64;
mod cabi_x86_win64;
mod cabi_wasm32;
mod callee;
mod common;
mod consts;
Expand Down