Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same RUSTFLAGS for building and testing bootstrap #49311

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Use the same RUSTFLAGS for building and testing bootstrap #49311

merged 1 commit into from
Mar 24, 2018

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Mar 23, 2018 •
edited
Loading

This avoids recompiling the whole dependency graph twice for every ./x.py test run.

Fixes #49215

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@SimonSapin
Copy link
Contributor Author

r? @Mark-Simulacrum

@SimonSapin SimonSapin added A-build T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 23, 2018
@SimonSapin SimonSapin mentioned this pull request Mar 23, 2018
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 23, 2018

📌 Commit e993e62 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49311 - SimonSapin:bootstrap-vs-rustflags-t…
0615e6b 
…he-return, r=Mark-Simulacrum

Use the same RUSTFLAGS for building and testing `bootstrap`

This avoids recompiling the whole dependency graph twice for every `./x.py test` run.

Fixes rust-lang#49215
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Closed
@bors
Copy link
Contributor

bors commented Mar 23, 2018

⌛ Testing commit e993e62 with merge 4be5d36...

bors added a commit that referenced this pull request Mar 23, 2018
@bors
Auto merge of #49311 - SimonSapin:bootstrap-vs-rustflags-the-return, …
4be5d36 
…r=Mark-Simulacrum

Use the same RUSTFLAGS for building and testing `bootstrap`

This avoids recompiling the whole dependency graph twice for every `./x.py test` run.

Fixes #49215
@bors
Copy link
Contributor

bors commented Mar 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 4be5d36 to master...

@bors bors merged commit e993e62 into rust-lang:master Mar 24, 2018
@SimonSapin SimonSapin deleted the bootstrap-vs-rustflags-the-return branch March 30, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SimonSapin @rust-highfive @Mark-Simulacrum @bors @nikomatsakis