Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collapse toggle insertions on impl with docs #49429

Merged
merged 1 commit into from Mar 29, 2018
Merged

Fix collapse toggle insertions on impl with docs #49429

merged 1 commit into from Mar 29, 2018

Conversation

GuillaumeGomez
Copy link
Member

Just went through this one randomly... When an impl has docs, the collapse toggle isn't generated. This fixes it.

r? @QuietMisdreavus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 28, 2018

📌 Commit 8be26a2 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49429 - GuillaumeGomez:fix-collapse-toggle-…
611ceef 
…insertion, r=QuietMisdreavus

Fix collapse toggle insertions on impl with docs

Just went through this one randomly... When an impl has docs, the collapse toggle isn't generated. This fixes it.

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Mar 28, 2018
Merged
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49460 - kennytm:rollup, r=kennytm
d52c44e 
Rollup of 12 pull requests

- Successful merges: #49243, #49329, #49364, #49400, #49405, #49427, #49428, #49429, #49439, #49442, #49444, #49452
- Failed merges:
@bors bors merged commit 8be26a2 into rust-lang:master Mar 29, 2018
@GuillaumeGomez GuillaumeGomez deleted the fix-collapse-toggle-insertion branch March 29, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive