Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename must-compile-successfully into compile-pass #49585

Merged
merged 1 commit into from
Apr 14, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/COMPILER_TESTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Some examples of `X` in `ignore-X`:

* `min-{gdb,lldb}-version`
* `min-llvm-version`
* `must-compile-successfully` for UI tests, indicates that the test is supposed
* `compile-pass` for UI tests, indicates that the test is supposed
to compile, as opposed to the default where the test is supposed to error out.
* `compile-flags` passes extra command-line args to the compiler,
e.g. `compile-flags -g` which forces debuginfo to be enabled.
Expand Down Expand Up @@ -134,7 +134,7 @@ so forth.
Normally, the test-runner checks that UI tests fail compilation. If you want
to do a UI test for code that *compiles* (e.g. to test warnings, or if you
have a collection of tests, only some of which error out), you can use the
`// must-compile-successfully` header command to have the test runner instead
`// compile-pass` header command to have the test runner instead
check that the test compiles successfully.

### Editing and updating the reference files
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// must-compile-successfully
// compile-pass

#![allow(warnings)]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// must-compile-successfully
// compile-pass

fn with_closure<F, A>(_: F)
where F: FnOnce(A, &u32)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// must-compile-successfully
// compile-pass

fn with_closure<F, A>(_: F)
where F: FnOnce(A, &u32)
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/issue-47309.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// See https://github.com/rust-lang/rust/issues/47309

// compile-flags:-Clink-dead-code
// must-compile-successfully
// compile-pass

#![crate_type="rlib"]

Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/rmeta-lib-pass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// compile-flags: --emit=metadata
// aux-build:rmeta_rlib.rs
// no-prefer-dynamic
// must-compile-successfully
// compile-pass

// Check that building a metadata crate works with a dependent, rlib crate.
// This is a cfail test since there is no executable to run.
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/rmeta-pass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// compile-flags: --emit=metadata
// aux-build:rmeta_meta.rs
// no-prefer-dynamic
// must-compile-successfully
// compile-pass

// Check that building a metadata crate works with a dependent, metadata-only
// crate.
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/rmeta-priv-warn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// compile-flags: --emit=metadata
// no-prefer-dynamic
// must-compile-successfully
// compile-pass

#[deny(warnings)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental-fulldeps/incremental_proc_macro.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// aux-build:incremental_proc_macro_aux.rs
// ignore-stage1
// revisions: cfail1 cfail2
// must-compile-successfully
// compile-pass

// This test makes sure that we still find the proc-macro registrar function
// when we compile proc-macros incrementally (see #47292).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// aux-build:point.rs
// must-compile-successfully
// compile-pass

#![feature(rustc_attrs)]
#![feature(stmt_expr_attributes)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/change_add_field/struct_point.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// must-compile-successfully
// compile-pass

#![feature(rustc_attrs)]
#![feature(stmt_expr_attributes)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/change_crate_dep_kind.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph -Cpanic=unwind
// must-compile-successfully
// compile-pass

#![feature(panic_unwind)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/change_private_fn/struct_point.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// must-compile-successfully
// compile-pass

#![feature(rustc_attrs)]
#![feature(stmt_expr_attributes)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/change_private_fn_cc/struct_point.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// aux-build:point.rs
// must-compile-successfully
// compile-pass

#![crate_type = "rlib"]
#![feature(rustc_attrs)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// must-compile-successfully
// compile-pass

#![feature(rustc_attrs)]
#![feature(stmt_expr_attributes)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// aux-build:point.rs
// must-compile-successfully
// compile-pass

#![crate_type = "rlib"]
#![feature(rustc_attrs)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// must-compile-successfully
// compile-pass

#![crate_type = "rlib"]
#![feature(rustc_attrs)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

// revisions:cfail1 cfail2
// compile-flags: -Z query-dep-graph
// must-compile-successfully
// compile-pass

#![crate_type = "rlib"]
#![feature(rustc_attrs)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/call_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/closure_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/consts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/enum_constructors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/enum_defs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// results in a change of the ICH for the enum's metadata, and that it stays
// the same between rev2 and rev3.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/exported_vs_not.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/extern_mods.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/for_loops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/function_interfaces.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/if_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/indexing_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/inherent_impls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/inline_asm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/let_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/loop_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/match_expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/panic_exprs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -C debug-assertions

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/statics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/struct_constructors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/struct_defs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// results in a change of the ICH for the struct's metadata, and that it stays
// the same between rev2 and rev3.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/trait_defs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// results in a change of the ICH for the trait's metadata, and that it stays
// the same between rev2 and rev3.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/trait_impls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/type_defs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// results in a change of the ICH for the enum's metadata, and that it stays
// the same between rev2 and rev3.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/unary_and_binary_exprs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
2 changes: 1 addition & 1 deletion src/test/incremental/hashes/while_let_loops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// and make sure that the hash has changed, then change nothing between rev2 and
// rev3 and make sure that the hash has not changed.

// must-compile-successfully
// compile-pass
// revisions: cfail1 cfail2 cfail3
// compile-flags: -Z query-dep-graph -Zincremental-ignore-spans

Expand Down
Loading