Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another circular deps link args issue #49672

Merged
merged 1 commit into from
Apr 7, 2018

Commits on Apr 4, 2018

  1. Fix another circulare deps link args issue

    It turns out that the support in rust-lang#49316 wasn't enough to handle all cases
    notably the example in rust-lang#48661. The underlying bug was connected to panic=abort
    where lang items were listed in the `missing_lang_items` sets but didn't
    actually exist anywhere.
    
    This caused the linker backend to deduce that start-group/end-group wasn't
    needed because not all items were defined. Instead the missing lang items that
    don't actually need to have a definition are filtered out and not considered for
    the start-group/end-group arguments
    
    Closes rust-lang#48661
    alexcrichton committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    48ede3f View commit details
    Browse the repository at this point in the history