Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inherent methods in libcore for [T], [u8], str, f32, and f64 #49896

Merged
merged 7 commits into from Apr 22, 2018
Merged

Add inherent methods in libcore for [T], [u8], str, f32, and f64 #49896

merged 7 commits into from Apr 22, 2018

Commits on Apr 21, 2018

  1. Remove unused methods on the private Wtf8 type 

    The type and its direct parent module are `pub`, but they’re not reachable outside of std
    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    5722567 View commit details
    Browse the repository at this point in the history

  2. Move non-allocating [u8] inherent methods to libcore 

    Fixes rust-lang#45803
    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    de8ed6a View commit details
    Browse the repository at this point in the history

  3. Replace SliceExt with inherent [T] methods in libcore

    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    90f29fb View commit details
    Browse the repository at this point in the history

  4. Replace StrExt with inherent str methods in libcore

    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    f0705bf View commit details
    Browse the repository at this point in the history

  5. Add some f32 and f64 inherent methods in libcore 

    … previously in the unstable core::num::Float trait.

Per rust-lang#32110 (comment),
the `abs`, `signum`, and `powi` methods are *not* included for now
since they rely on LLVM intrinsics and we haven’t determined yet whether
those instrinsics lower to calls to libm functions on any platform.
    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    8a374f2 View commit details
    Browse the repository at this point in the history

  6. Move intrinsics-based float methods out of libcore into libstd 

    Affected methods are `abs`, `signum`, and `powi`.
CC rust-lang#32110 (comment)
    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    18ab16b View commit details
    Browse the repository at this point in the history

  7. Make the unstable StrExt and SliceExt traits private to libcore in no… 

    …t(stage0)

`Float` still needs to be public for libcore unit tests.
    @SimonSapin
    SimonSapin committed Apr 21, 2018
    Copy the full SHA
    70fdd1b View commit details
    Browse the repository at this point in the history