Stabilize dyn trait #49968

pvdrz · 2018-04-14T19:25:59Z

This PR stabilizes RFC 2113. I followed the stabilization guide.

Related issue: #49218

rust-highfive · 2018-04-14T19:26:09Z

(rust_highfive has picked a reviewer for you, use r? to override)

bors · 2018-04-16T23:27:16Z

☔ The latest upstream changes (presumably #50003) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2018-04-18T16:14:34Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:47] configure: rust.quiet-tests     := True
---
[00:34:35] error: this feature has been stable since 1.27.0. Attribute no longer needed
[00:34:35]   --> librustdoc/lib.rs:26:12
[00:34:35]    |
[00:34:35] 26 | #![feature(dyn_trait)]
---
[00:34:36] Makefile:28: recipe for target 'all' failed
[00:34:36] make: *** [all] Error 1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2018-04-22T00:07:25Z

☔ The latest upstream changes (presumably #50121) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2018-04-24T15:33:07Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:46:39] ....................................................................................................
[00:46:43] ....................................................................................................
[00:46:48] ....................................................................................................
[00:46:53] ....................................................................................................
[00:47:00] ..............................................F.....................................................
[00:47:14] ....................................................................................................
[00:47:22] ..............................i.....................................................................
[00:47:28] ......i.............................................................................................
[00:47:35] ......................ii............................................................................

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-04-24T20:25:59Z

@TimNN btw that message doesn't seem to include the error =)

pvdrz · 2018-04-25T01:04:03Z

I'm having trouble with llvm, I'm going to rebuild everything from scratch

pvdrz · 2018-04-25T16:16:59Z

@nikomatsakis I think we are ready

nikomatsakis · 2018-04-25T16:58:08Z

r=me once travis is happy

nikomatsakis · 2018-04-25T17:33:55Z

@bors r+

bors · 2018-04-25T17:33:56Z

📌 Commit 3b34dbf has been approved by nikomatsakis

rust-highfive · 2018-04-25T17:46:26Z

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:56] configure: llvm.assertions      := True
[00:00:56] configure: build.locked-deps    := True
[00:00:56] configure: llvm.ccache          := sccache
[00:00:56] configure: build.openssl-static := True
[00:00:56] configure: build.configure-args := ['--enable-quiet-tests', '--enable-sccache', ' ...
[00:00:56] configure: writing `config.toml` in current directory
[00:00:56] configure: 
[00:00:56] configure: run `python /checkout/x.py --help`
[00:00:56] configure: 
---
[00:07:27]    Compiling rand v0.4.2
[00:07:27]    Compiling remove_dir_all v0.5.1
[00:07:28]    Compiling tempdir v0.3.7
[00:07:28]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:07:29] error[E0658]: `dyn Trait` syntax is unstable (see issue #44662)
[00:07:29]     |
[00:07:29]     |
[00:07:29] 166 |     let emitter: Box<dyn Emitter + sync::Send> = match error_format {
[00:07:29]     |
[00:07:29]     |
[00:07:29]     = help: add #![feature(dyn_trait)] to the crate attributes to enable
[00:07:29] error: aborting due to previous error
[00:07:29] 
[00:07:29] For more information about this error, try `rustc --explain E0658`.
[00:07:29] error: Could not compile `rustdoc`.
[00:07:29] error: Could not compile `rustdoc`.
[00:07:29] 
[00:07:29] Caused by:
[00:07:29]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name rustdoc librustdoc/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,metadata -C debug-assertions=off -C overflow-checks=on -C metadata=53bc6cad8d025cf8 -C extra-filename=-53bc6cad8d025cf8 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/i686-pc-windows-gnu/release/deps --target i686-pc-windows-gnu -C incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/i686-pc-windows-gnu/release/incremental -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/i686-pc-windows-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/release/deps --extern pulldown_cmark=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/i686-pc-windows-gnu/release/deps/libpulldown_cmark-8f75380f3365e775.rmeta --extern tempdir=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools/i686-pc-windows-gnu/release/deps/libtempdir-4d964115e60069d9.rmeta -L native=/cargo/registry/src/github.com-1ecc6299db9ec823/winapi-i686-pc-windows-gnu-0.4.0/lib` (exit code: 101)
[00:07:29] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "--target" "i686-pc-windows-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml" "--message-format" "json"
[00:07:29] expected success, got: exit code: 101
[00:07:29] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:07:29] travis_fold:end:stage0-rustdoc

[00:07:29] travis_time:end:stage0-rustdoc:start=1524673242704764431,finish=1524673251062949500,duration=8358185069

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-04-25T17:52:14Z

@bors r- -- travis

nikomatsakis · 2018-04-25T19:34:39Z

@bors r+

bors · 2018-04-25T19:34:40Z

📌 Commit 545f5f5 has been approved by nikomatsakis

bors · 2018-04-27T12:13:29Z

⌛ Testing commit 545f5f5574a06896611508ad4406b97702b5d081 with merge 5264567ea97ef1cb749cf53543dfcf1c99d1fa7c...

bors · 2018-04-27T12:24:13Z

💔 Test failed - status-travis

pvdrz · 2018-04-27T18:43:53Z

@nikomatsakis I think it's ready

kennytm · 2018-04-27T19:27:30Z

@bors r=nikomatsakis

bors · 2018-04-27T19:27:31Z

📌 Commit b5c7cbf has been approved by nikomatsakis

…komatsakis Stabilize dyn trait This PR stabilizes RFC 2113. I followed the [stabilization guide](https://forge.rust-lang.org/stabilization-guide.html). Related issue: rust-lang#49218

Rollup of 9 pull requests Successful merges: - #49858 (std: Mark `ptr::Unique` with `#[doc(hidden)]`) - #49968 (Stabilize dyn trait) - #50192 (Add some utilities to `libsyntax`) - #50251 (rustc: Disable threads in LLD for wasm) - #50263 (rustc: Emit `uwtable` for allocator shims) - #50269 (Update `parking_lot` dependencies) - #50273 (Allow #[inline] on closures) - #50284 (fix search load page failure) - #50257 (Don't ICE on tuple struct ctor with incorrect arg count) Failed merges:

alercah · 2018-05-03T19:51:17Z

Not sure if this is the best place to ask, but in the future, when a sub-feature is split off for separate stabilization, can we please ensure that docs PRs are filed for the sub-feature as a prerequisite? We have rust-lang/reference#279 for dyn Trait, but looking at the tracking issue #44662, it looks like it isn't stabilized, so it would otherwise slip through the cracks until the full feature was done. (cc @Havvy)

steveklabnik · 2018-05-03T22:56:10Z

@alercah for the stuff relating to the edition, we relaxed the requirement to "file an issue". I made issues for everything in RBE and the book, but I thought yinz were handling the reference your own way. If it's easier, you all may want to copy over https://github.com/rust-lang/book/issues?q=is%3Aopen+is%3Aissue+label%3A%22Blocking+Rust+2018%22, or I'm happy to do it too, whatever works for you all.

that being said, yeah, when stuff gets split off, commenting in those issues about it would be 👍

alercah · 2018-05-03T23:00:27Z

Oops sorry, yes, I meant issues, not PRs. @matthewjasper filed a number of issues for the reference for Rust 2018 features, and that's good, but there are always going to be stabilizations that aren't planned out like that. So the point that I was trying to make subtly, and apparently failed at because I mixed things up, was that I think that at some point someone should have asked "Do necessary issues exist on docs repositories?" before this got merged. It's not clear to me that it wasn't because we already have one for dyn Trait writ large, in which case it just slipped through, or that it's because nobody checked.

As a side note, the stabilization guide needs updating, which would probably reduce the likelihood of future miscommunication.

steveklabnik · 2018-05-04T15:53:44Z

I think that at some point someone should have asked "Do necessary issues exist on docs repositories?" before this got merged.

yes please! Agree 1000%.

rust-highfive assigned nikomatsakis Apr 14, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2018

nikomatsakis approved these changes Apr 25, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2018

pietroalbini added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 27, 2018

This comment has been minimized.

Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2018

This comment has been minimized.

Sign in to view

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2018

pvdrz added 9 commits April 27, 2018 10:04

stop requiring the feature-gate to use dyn_trait

199ee32

removed dyn_trait feature from tests

c86f1c8

dyn_trait feature-gate just for stage0

0efb567

removed linting for dyn_trait

55a653d

updated stderr files and removed feature-gate test for dyn_trait

4bf35f9

fixed rustc version for dyn_trait

72a8eb9

removed dyn trait attribute from librustdoc

cadf251

fixed tests

b80472d

rustdoc asks for dyn_trait feature in stage0

b5c7cbf

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2018

kennytm mentioned this pull request Apr 27, 2018

Rollup of 9 pull requests #50290

Merged

bors merged commit b5c7cbf into rust-lang:master Apr 27, 2018

pvdrz deleted the stabilize_dyn branch May 2, 2018 03:40

nikomatsakis mentioned this pull request Jul 5, 2018

stabilize dyn Trait in Rust 2015 #49218

Closed

This was referenced Apr 16, 2019

cargo check fails only in incremental mode #58291

Closed

april 2018 trait resolution regression #60010

Closed

lqd mentioned this pull request Jul 17, 2019

ICE: Generic type alias to invalid type crashes during type check on latest stable #62742

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize dyn trait #49968

Stabilize dyn trait #49968

pvdrz commented Apr 14, 2018 •

edited

Loading

rust-highfive commented Apr 14, 2018

bors commented Apr 16, 2018

rust-highfive commented Apr 18, 2018

bors commented Apr 22, 2018

rust-highfive commented Apr 24, 2018

nikomatsakis commented Apr 24, 2018

pvdrz commented Apr 25, 2018

pvdrz commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

rust-highfive commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

bors commented Apr 27, 2018

bors commented Apr 27, 2018

This comment has been minimized.

This comment has been minimized.

pvdrz commented Apr 27, 2018

kennytm commented Apr 27, 2018

bors commented Apr 27, 2018

alercah commented May 3, 2018

steveklabnik commented May 3, 2018 •

edited

Loading

alercah commented May 3, 2018

steveklabnik commented May 4, 2018

Stabilize dyn trait #49968

Stabilize dyn trait #49968

Conversation

pvdrz commented Apr 14, 2018 • edited Loading

rust-highfive commented Apr 14, 2018

bors commented Apr 16, 2018

rust-highfive commented Apr 18, 2018

bors commented Apr 22, 2018

rust-highfive commented Apr 24, 2018

nikomatsakis commented Apr 24, 2018

pvdrz commented Apr 25, 2018

pvdrz commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

rust-highfive commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

nikomatsakis commented Apr 25, 2018

bors commented Apr 25, 2018

bors commented Apr 27, 2018

bors commented Apr 27, 2018

This comment has been minimized.

This comment has been minimized.

pvdrz commented Apr 27, 2018

kennytm commented Apr 27, 2018

bors commented Apr 27, 2018

alercah commented May 3, 2018

steveklabnik commented May 3, 2018 • edited Loading

alercah commented May 3, 2018

steveklabnik commented May 4, 2018

pvdrz commented Apr 14, 2018 •

edited

Loading

steveklabnik commented May 3, 2018 •

edited

Loading