Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't see issue #0 #49985

Merged
merged 1 commit into from
Apr 24, 2018
Merged

don't see issue #0 #49985

merged 1 commit into from
Apr 24, 2018

Commits on Apr 15, 2018

  1. don't see issue #0

    The unstable-feature attribute requires an issue (neglecting it is
    E0547), which gets used in the error messages. Unfortunately, there are
    some cases where "0" is apparently used a placeholder where no issue
    exists, directing the user to see the (nonexistent) issue #0. (It would
    have been better to either let `issue` be optional—compare to how issue
    is an `Option<u32>` in the feature-gate declarations in
    libsyntax/feature-gate.rs—or actually require that an issue be created.)
    Rather than endeavoring to change how `#[unstable]` works at this time
    (given competing contributor and reviewer priorities), this simple patch
    proposes the less-ambitious solution of just not adding the "(see
    issue)" note when the number is zero.
    
    Resolves rust-lang#49983.
    zackmdavis committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    e77110e View commit details
    Browse the repository at this point in the history