Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on pointless #[derive] in more places #50092

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Warn on pointless #[derive] in more places #50092

merged 1 commit into from
Apr 30, 2018

Commits on Apr 29, 2018

  1. Warn on pointless #[derive] in more places 

    This fixes the regression in rust-lang#49934 and ensures that unused `#[derive]`s on statements, expressions and generic type parameters survive to trip the `unused_attributes` lint. For `#[derive]` on macro invocations it has a hardcoded warning since linting occurs after expansion. This also adds regression testing for some nodes that were already warning properly.

closes rust-lang#49934
    @abonander
    abonander committed Apr 29, 2018
    Configuration menu
    Copy the full SHA
    f16d2ff View commit details
    Browse the repository at this point in the history