Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Process backports #50224

Merged
merged 4 commits into from
Apr 25, 2018
Merged

[beta] Process backports #50224

merged 4 commits into from
Apr 25, 2018

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Apr 25, 2018 •
edited
Loading

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@pietroalbini pietroalbini changed the title [beta] Backport #50110 [beta] Process backports Apr 25, 2018
@pietroalbini
Copy link
Member Author

Also added #49779 (still needs beta-accepted).

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ p=1

Thanks @pietroalbini!

@bors
Copy link
Contributor

bors commented Apr 25, 2018

📌 Commit 656d825 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018
@bors
Copy link
Contributor

bors commented Apr 25, 2018

⌛ Testing commit 656d825 with merge 1861fb5...

bors added a commit that referenced this pull request Apr 25, 2018
@bors
Auto merge of #50224 - pietroalbini:beta-backports, r=alexcrichton
1861fb5 
[beta] Process backports

* #49779: Don't report compile-time errors for promoteds
* #50110: Warn on all erroneous constants
@bors
Copy link
Contributor

bors commented Apr 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1861fb5 to beta...

@bors bors merged commit 656d825 into rust-lang:beta Apr 25, 2018
@pietroalbini pietroalbini deleted the beta-backports branch April 25, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pietroalbini @rust-highfive @alexcrichton @bors @estebank @oli-obk