Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Process backports #50298

Merged
merged 1 commit into from
Apr 28, 2018
Merged

[Beta] Process backports #50298

merged 1 commit into from
Apr 28, 2018

Conversation

pietroalbini
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2018
@pietroalbini
Copy link
Member Author

Let's wait until #50092 is merged, to avoid doing two different backports.

@pietroalbini pietroalbini changed the title [Beta] Backport #50257 [Beta] Process backports Apr 28, 2018
@pietroalbini
Copy link
Member Author

#50092 is going through another code iteration, so we can merge this.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 28, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2018

📌 Commit 6c07e81 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2018
@pietroalbini
Copy link
Member Author

@bors p=10 (beta backport)

@bors
Copy link
Contributor

bors commented Apr 28, 2018

⌛ Testing commit 6c07e81 with merge ceaeabf...

bors added a commit that referenced this pull request Apr 28, 2018
@bors
Auto merge of #50298 - pietroalbini:beta-backports, r=oli-obk
ceaeabf 
[Beta] Process backports

* #50257: Don't ICE on tuple struct ctor with incorrect arg count
@bors
Copy link
Contributor

bors commented Apr 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing ceaeabf to beta...

@bors bors merged commit 6c07e81 into rust-lang:beta Apr 28, 2018
@pietroalbini pietroalbini deleted the beta-backports branch April 28, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pietroalbini @rust-highfive @oli-obk @bors @michaelwoerister @estebank