Propose backport of "Fix self referential impl Trait substitutions" #50737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A high impact bug because a lot of common traits use a `Self` substitution by default. Should be backported to beta. There was a check for this which wasn't catching all cases, it was made more robust. Fixes rust-lang#49376 Fixes rust-lang#50626 r? @petrochenkov
|
|
rust-highfive
added
the
S-waiting-on-review
leoyvens
changed the title
petrochenkov
added
the
beta-nominated
|
I don't know what is the process for accepting backports to beta. |
pietroalbini
removed
the
beta-nominated
|
The |
|
The queue is long enough, let's not have two different backport PRs open. Cherry-picked this into #50741. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #50694 which was a small fix for a significant issue.
r? @petrochenkov