Commits on May 18, 2018

1. in which the unused shorthand field pattern debacle/saga continues …

   In e4b1a79 (rust-lang#47922), we corrected erroneous suggestions for unused
   shorthand field pattern bindings, suggesting `field: _` where the
   previous suggestion of `_field` wouldn't even have compiled
   (rust-lang#47390). Soon, it was revealed that this was insufficient (rust-lang#50303), and
   the fix was extended to references, slices, &c. (rust-lang#50327) But even this
   proved inadequate, as the erroneous suggestions were still being issued
   for patterns in local (`let`) bindings (rust-lang#50804). Here, we yank the
   shorthand-detection and variable/node registration code into a new
   common function that can be called while visiting both match arms and
   `let` bindings.
   
   Resolves rust-lang#50804.

   

   zackmdavis committed May 18, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 59782f4
   • Browse repository at this point

   Copy the full SHA

   59782f4 View commit details

   Browse the repository at this point in the history