Lint checking for non-implicitly-copyable-typarams #5101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, that was intentional. It was generally considered that this warning did more harm than good. Perhaps though it is good to bring it back, and just change the default setting to disabled. |
|
Ahh, I see. Thanks! If that was intentional, I have nothing to say against it. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
add `let_underscore_lock` lint closes rust-lang#1574 changelog: add `let_underscore_lock` lint I am not entirely sure about my docs/messages wording here, improvements are welcome
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
Add `let_underscore_drop` This line generalizes `let_underscore_lock` (rust-lang#5101) to warn about any initializer expression that implements `Drop`. So, for example, the following would generate a warning: ```rust struct Droppable; impl Drop for Droppable { fn drop(&mut self) {} } let _ = Droppable; ``` I tried to preserve the original `let_underscore_lock` functionality in the sense that the warning generated for ```rust let _ = mutex.lock(); ``` should be unchanged. *Please keep the line below* changelog: Add lint [`let_underscore_drop`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint checking for non-implicitly-copyable-typarams has somehow been removed at a380df8, but I don't think it is intentional.