Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize entry-or-default #51079

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Stabilize entry-or-default #51079

merged 1 commit into from
Jun 10, 2018

Conversation

GuillaumeGomez
Copy link
Member

Fixes #44324.

cc @SimonSapin

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2018
@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label May 26, 2018
@kennytm kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 26, 2018
@Mark-Simulacrum
Copy link
Member

r? @SimonSapin (but looks good to me)

@shepmaster
Copy link
Member

Ping from triage, @SimonSapin !

@SimonSapin
Copy link
Contributor

Uh, sorry I let this slip through.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2018

📌 Commit 910452a has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2018
@bors
Copy link
Contributor

bors commented Jun 10, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 10, 2018
@GuillaumeGomez
Copy link
Member Author

Rebased.

@bors: r=SimonSapin

@bors
Copy link
Contributor

bors commented Jun 10, 2018

📌 Commit 861c7cb has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2018
@bors
Copy link
Contributor

bors commented Jun 10, 2018

⌛ Testing commit 861c7cb with merge 900037e...

bors added a commit that referenced this pull request Jun 10, 2018
@bors
Auto merge of #51079 - GuillaumeGomez:stabilize-entry-or-default, r=S…
900037e 
…imonSapin

Stabilize entry-or-default

Fixes #44324.

cc @SimonSapin
@bors
Copy link
Contributor

bors commented Jun 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: SimonSapin
Pushing 900037e to master...

@bors bors merged commit 861c7cb into rust-lang:master Jun 10, 2018
@GuillaumeGomez GuillaumeGomez deleted the stabilize-entry-or-default branch June 10, 2018 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@GuillaumeGomez @rust-highfive @Mark-Simulacrum @shepmaster @SimonSapin @bors @kennytm @Centril