Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.27.0 #51261

Merged
merged 1 commit into from Jun 12, 2018
Merged

Updated RELEASES.md for 1.27.0 #51261

merged 1 commit into from Jun 12, 2018

Conversation

XAMPPRocky
Copy link
Member

Rendered
r? @Mark-Simulacrum
cc @rust-lang/release

@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels May 31, 2018
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2018
RELEASES.md Outdated
now stable.][48851] e.g.
`fn foo<#[lifetime_attr] 'a, #[type_attr] T: 'a>() {}`
- [The `#[must_use]` attribute can now also be used on functions as well as
types.][48925] Which provides a lint that by default warns users when the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Which/it

RELEASES.md Outdated
- [`HashMap::remove_entry`]
- [`Take::set_limit`]
- [`fs::read`]
- [`fs::write`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs::{read, write} were stabilized in 1.26 as far as I can tell.

RELEASES.md Outdated
----
- [Added “The Rustc book” into the official documentation.][49707]
[“The Rustc book”] documents and teaches how to use the rustc compiler.
- [All books are now seachable.][49623]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/seachable/searchable

RELEASES.md Outdated
work.][49896] e.g. `::core::prelude::v1::StrExt::is_empty("")` will not
compile, `"".is_empty()` will still compile.
- [`Debug` output on `atomic::{AtomicBool, AtomicIsize, AtomicPtr, AtomicUsize}`
will only printthe inner type.][48553] e.g.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/printthe/print the

RELEASES.md Outdated
- [`Debug` output on `atomic::{AtomicBool, AtomicIsize, AtomicPtr, AtomicUsize}`
will only printthe inner type.][48553] e.g.
`print!("{:?}", AtomicBool::new(true))` will print `true`
not `AtomicBool(false)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/false/true

RELEASES.md Outdated
- [`[T]::rsplit`]
- [`[T]::swap_with_slice`]
- [`fs::read`]
- [`fs::write`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs::{read, write} where stabilized in 1.26

RELEASES.md Outdated
- [A lot of methods for `[u8]`, `f32`, and `f64` previously only available in
std are now available in core.][49896]
- [`memchr::repeat_byte` is now optimised to have a reduced code
size footprint.][50398] It will also be slightly faster on 64bit platforms.
Copy link
Member

@kennytm kennytm May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this item worth putting into the release note. The original PR doesn't have the relnote label either. The perf isn't really impressive, just as the PR's title indicated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes have never been exclusively pull requests with the relnotes label. I always like including optimisations as it is something a lot of people are interested in. If you feel strongly about its inclusion I'm fine with removing it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do feel quite strongly because memchr::repeat_byte isn't a public API.

We could say public APIs like <str>::{contains, find, rfind, matches, split, replace} with a char pattern becomes a bit faster.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot that memchr is not in the public API. 😅

RELEASES.md Outdated
[`Iterator::try_for_each`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.try_for_each
[`NonNull::cast`]: https://doc.rust-lang.org/std/ptr/struct.NonNull.html#method.cast
[`Option::filter`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.filter
[`String::replace_range`]: https://doc.rust-lang.org/beta/std/string/struct.String.html#method.replace_range
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should not point to beta

RELEASES.md Outdated
disable this feature ahead of time by setting any of the following `autobins`,
`autobenches`, `autoexamples`, `autotests` to false.
- [Cargo will now cache compiler information.][5359] This can be disabled by the
`CARGO_CACHE_RUSTC_INFO` environment variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify that you disable it by setting the env var to 0 (CARGO_CACHE_RUSTC_INFO=0)

@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 31, 2018
RELEASES.md Outdated
be used as an identifer.
- [The dyn syntax is now available.][49968] This syntax is equivalent to the
bare `Trait` syntax, and should make it clearer when being used in tandem with
`impl Trait`. Since it is equivalent to follow syntax has the same behaviour.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "the following syntax has" and to end with a colon there?

RELEASES.md Outdated
}
```
- [The maximum number for `repr(align(N))` is now 2²⁹.][50378] Previously you
could enter higher numbers but they were not supported by LLVM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we're missing a

512MB alignment ought to be enough for anybody

quote here

RELEASES.md Outdated
to `Self`.][49630]
- [`std::str::replace` now has the `#[must_use]` attribute][50177] to clarify
that the operation isn't done in place.
- [`ManuallyDrop::new` is now a constant function.][50148]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is marked rustc_const_unstable, so it's not stable yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks like that relnotes label was out of date.

RELEASES.md Outdated
`readme`, and `repository` fields.][5386]
- [Added the `--target-dir` optional argument.][5393] This allows you to specify
a different directory than `target` for placing compilation artifacts.
- [Added the `--out-dir` optional argument to `cargo-build`.][5203] Allowing you
Copy link
Contributor

@ehuss ehuss Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--out-dir is an unstable, nightly-only feature.

RELEASES.md Outdated
will only print the inner type.][48553] e.g.
`print!("{:?}", AtomicBool::new(true))` will print `true`
not `AtomicBool(true)`.
- [`?` can no longer be a seperator in macros.][49719] e.g. the following will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/seperator/separator

RELEASES.md Outdated
`fn foo<#[lifetime_attr] 'a, #[type_attr] T: 'a>() {}`
- [The `#[must_use]` attribute can now also be used on functions as well as
types.][48925] It provides a lint that by default warns users when the
return type is not being used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this read "the return value of the function"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer: ".. when the value, returned by the function, is not used." :)

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 2, 2018
@bors
Copy link
Contributor

bors commented Jun 2, 2018

☔ The latest upstream changes (presumably #51287) made this pull request unmergeable. Please resolve the merge conflicts.

@TimNN TimNN added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2018
RELEASES.md Outdated

Libraries
---------
- [SIMD(Single Instruction Multiple Data) on x86/x86_64 is now stable.][49664]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a space before (

@pietroalbini
Copy link
Member

By the way @Aaronepower, you should rebase this on top of master soonish, it would be bad being too late to backport this into beta.

@Mark-Simulacrum
Copy link
Member

My current plan is to do the backport simultaneous with promotion to stable since this cannot fail if we run out of time

@XAMPPRocky XAMPPRocky force-pushed the master branch 2 times, most recently from e803025 to 54b5132 Compare June 12, 2018 15:40
@XAMPPRocky
Copy link
Member Author

@pietroalbini Yeah, I was waiting on #51507 to be merged before I rebased in case somehow that also caused a merged conflict. It's rebased now.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 12, 2018

📌 Commit 46f74a3 has been approved by Mark-Simulacrum

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 12, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 12, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 12, 2018
bors added a commit that referenced this pull request Jun 12, 2018
Rollup of 3 pull requests

Successful merges:

 - #51261 (Updated RELEASES.md for 1.27.0)
 - #51502 (Make parse_seq_to_end and parse_path public)
 - #51510 (Long diagnostic for E0538)

Failed merges:
@bors bors merged commit 46f74a3 into rust-lang:master Jun 12, 2018
bors added a commit that referenced this pull request Jun 16, 2018
[beta] Rollup backports

* #51261: Updated RELEASES.md for 1.27.0
* #51591: Remove `?` macro separator compatibility note from 1.27 release notes

r? @Mark-Simulacrum
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet