Add Ref/RefMut map_split method #51466

joshlf · Jun 10, 2018

As proposed here.

TLDR: Add a map_split method that allows multiple RefMuts to exist simultaneously so long as they refer to non-overlapping regions of the original RefCell. This is useful for things like the slice split_at_mut method.

rust-highfive · Jun 10, 2018

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · Jun 10, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:47]    Compiling cc v1.0.15
[00:03:47]    Compiling core v0.0.0 (file:///checkout/src/libcore)
[00:03:47]    Compiling unwind v0.0.0 (file:///checkout/src/libunwind)
[00:03:47]    Compiling build_helper v0.1.0 (file:///checkout/src/build_helper)
[00:03:50] error[E0541]: unknown meta item 'since'
[00:03:50]     --> libcore/cell.rs:1145:47
[00:03:50]      |
[00:03:50] 1145 |     #[unstable(feature = "refcell_map_split", since = "0")]
[00:03:50] 
[00:03:50] 
[00:03:50] error[E0541]: unknown meta item 'since'
[00:03:50]     --> libcore/cell.rs:1231:47
[00:03:50]      |
[00:03:50] 1231 |     #[unstable(feature = "refcell_map_split", since = "0")]
[00:03:50] 
[00:03:52]    Compiling compiler_builtins v0.0.0 (file:///checkout/src/rustc/compiler_builtins_shim)
[00:03:52]    Compiling cmake v0.1.30
[00:03:52]    Compiling alloc_jemalloc v0.0.0 (file:///checkout/src/liballoc_jemalloc)
---
[00:04:00] Caused by:
[00:04:00]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name core libcore/lib.rs --color always --error-format json --crate-type lib --emit=dep-info,link -C opt-level=2 -C metadata=e9cdce497aae9e81 -C extra-filename=-e9cdce497aae9e81 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps` (exit code: 101)
[00:04:00] warning: build failed, waiting for other jobs to finish...
[00:04:11] error: build failed
[00:04:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:04:11] expected success, got: exit code: 101
[00:04:11] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:04:11] travis_fold:end:stage0-std

[00:04:11] travis_time:end:stage0-std:start=1528609189357781357,finish=1528609213901463650,duration=24543682293


[00:04:11] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:11] Build completed unsuccessfully in 0:00:25
[00:04:11] Makefile:79: recipe for target 'tidy' failed
[00:04:11] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:28c73509
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0fc341af:start=1528609214449490020,finish=1528609214457192995,duration=7702975
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0bfb0b72
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0d561cc8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Jun 10, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:09:45] 
[01:09:45]    Doc-tests core
[01:09:57] 
[01:09:57] running 2079 tests
[01:10:09] ......................................F................F............................................
[01:10:39] ....................................................................................................
[01:10:55] ...............................i....................................................................
[01:11:07] ....................................................................................................
[01:11:19] ....................................................................................................
---
-linux-gnu
116828 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release
116028 ./obj/build/x86_64-unknown-linux-gnu/test/mir-opt
103932 ./obj/build/bootstrap/debug/incremental/bootstrap-c730863262pt
103928 ./obj/build/bootstrap/debug/incremental/bootstrap-c730863262pt/s-f1uiq6s958-zstklu-no75lmxs5rt9
102924 ./obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu
102920 ./obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release
99540 ./obj/build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/deps
91392 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · Jun 10, 2018

kennytm reviewed Jun 10, 2018

View changes

kennytm · Jun 10, 2018

src/libcore/cell.rs

+//
+// `Ref` and `RefMut` are both two words in size, and so there can never be
+// enough `Ref`s or `RefMut`s in existence to overflow half of the `usize`
+// range. Thus, a `BorrowFlag` will never overflow.


I doubt this, since you could forget a Ref. See #25841.

Good call. I'll make sure that this is asserted everywhere it could overflow.

OK, I believe I've gotten all of the cases.

rust-highfive · Jun 10, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:16:23] 
[01:16:23]    Doc-tests core
[01:16:35] 
[01:16:35] running 2079 tests
[01:16:48] .........................................F..............F...........................................
[01:17:20] ....................................................................................................
[01:17:37] ...............................i....................................................................
[01:17:49] ....................................................................................................
[01:18:02] ....................................................................................................
---
[01:21:17] ....................................................................................................
[01:21:30] .........i.............................................i.......................
[01:21:30] failures:
[01:21:30] 
[01:21:30] ---- cell.rs - cell::Ref<'b, T>::map_split (line 1139) stdout ----
[01:21:30] error[E0658]: use of unstable library feature 'refcell_map_split'
[01:21:30]  --> cell.rs:1144:20
[01:21:30]   |
[01:21:30] 8 | let (begin, end) = Ref::map_split(borrow, |a| a.split_at(2));
[01:21:30]   |
[01:21:30]   |
[01:21:30]   = help: add #![feature(refcell_map_split)] to the crate attributes to enable
[01:21:30] 
[01:21:30] thread 'cell.rs - cell::Ref<'b, T>::map_split (line 1139)' panicked at 'couldn't compile the test', librustdoc/test.rs:325:17
[01:21:30] 
[01:21:30] ---- cell.rs - cell::RefMut<'b, T>::map_split (line 1220) stdout ----
[01:21:30] ---- cell.rs - cell::RefMut<'b, T>::map_split (line 1220) stdout ----
[01:21:30] error[E0658]: use of unstable library feature 'refcell_map_split'
[01:21:30]  --> cell.rs:1226:24
[01:21:30]   |
[01:21:30] 9 |     let (begin, end) = RefMut::map_split(borrow, |a| a.split_at_mut(2));
[01:21:30]   |
[01:21:30]   |
[01:21:30]   = help: add #![feature(refcell_map_split)] to the crate attributes to enable
[01:21:30] 
[01:21:30] thread 'cell.rs - cell::RefMut<'b, T>::map_split (line 1220)' panicked at 'couldn't compile the test', librustdoc/test.rs:325:17
[01:21:30] 
[01:21:30] failures:
[01:21:30]     cell.rs - cell::Ref<'b, T>::map_split (line 1139)
[01:21:30]     cell.rs - cell::RefMut<'b, T>::map_split (line 1220)
[01:21:30]     cell.rs - cell::RefMut<'b, T>::map_split (line 1220)
[01:21:30] 
[01:21:30] test result: FAILED. 2074 passed; 2 failed; 3 ignored; 0 measured; 0 filtered out
[01:21:30] 
[01:21:30] error: test failed, to rerun pass '--doc'
[01:21:30] 
[01:21:30] 
[01:21:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:21:30] 
[01:21:30] 
[01:21:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:30] Build completed unsuccessfully in 0:34:19
[01:21:30] Build completed unsuccessfully in 0:34:19
[01:21:30] make: *** [check] Error 1
[01:21:30] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0a85adb8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · Jun 10, 2018

cc @RalfJung on the soundness of this (seems sound to me...)

It would be good to list more use cases this supports.
The one mentioned in the documentation can simply be written as:

let mut borrow = c.borrow_mut();
let (begin, end) = borrow.split_at_mut(2);
assert_eq!(*begin, [1, 2]);
assert_eq!(*end, [3, 4]);
begin.copy_from_slice(&[4, 3]);
end.copy_from_slice(&[2, 1]);

which seems more direct.

Centril · Jun 10, 2018

Centril reviewed Jun 10, 2018

View changes

Some improvement suggestions for documentation.

Centril · Jun 10, 2018

src/libcore/cell.rs

+    /// ```
+    /// use std::cell::{Ref, RefCell};
+    ///
+    /// let c = RefCell::new([1, 2, 3, 4]);


s/c/cell
s/a/slice

Centril · Jun 10, 2018

src/libcore/cell.rs

+    /// ```
+    /// use std::cell::{RefCell, RefMut};
+    ///
+    /// let c = RefCell::new([1, 2, 3, 4]);


s/c/cell
s/a/slice

shepmaster · Jun 10, 2018

Too deep for me!

r? @dtolnay

ExpHP · Jun 10, 2018

Why (U, U) instead of (U, V)?

dtolnay · Jun 10, 2018

dtolnay reviewed Jun 10, 2018

View changes

dtolnay · Jun 10, 2018

src/libcore/cell.rs

+// be enough `Ref`s or `RefMut`s in existence to overflow half of the `usize`
+// range. Thus, a `BorrowFlag` will probably never overflow. However, this is
+// not a guarantee, as a pathological program could repeatedly create and then
+// mem::drop `Ref`s or `RefMut`s. Thus, all code must explicitly check for


I believe the trouble arises from mem::forget, not mem::drop.

dtolnay · Jun 10, 2018

The implementation looks good to me. I agree that after split they should be able to have different types U, V.

joshlf · Jun 10, 2018

Why (U, U) instead of (U, V)?

Done.

Is there any canonical way to have the function return an arbitrary number of elements in the tuple (or at least, up to some reasonable bound, like 8)? I have a function called extract_range which has the signature extract_range<R: RangeBounds<usize>>(&mut [u8], range: R) -> (&mut [u8], &mut [u8], &mut [u8]), and I could imagine others having similar functions.

dtolnay · Jun 10, 2018

dtolnay reviewed Jun 10, 2018

View changes

dtolnay · Jun 10, 2018

src/libcore/cell.rs

+    /// assert_eq!(*begin, [1, 2]);
+    /// assert_eq!(*end, [3, 4]);
+    /// ```
+    #[unstable(feature = "refcell_map_split", issue = "51466")]


Please file a tracking issue separate from the PR.

Done: #51476

rust-highfive · Jun 10, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:46] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:46] tidy error: /checkout/src/libcore/cell.rs:1235: line longer than 100 chars
[00:04:48] some tidy checks failed
[00:04:48] 
[00:04:48] 
[00:04:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:48] 
[00:04:48] 
[00:04:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:48] Build completed unsuccessfully in 0:01:44
[00:04:48] Build completed unsuccessfully in 0:01:44
[00:04:48] Makefile:79: recipe for target 'tidy' failed
[00:04:48] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1f9f2576
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:064dc514:start=1528650682346797564,finish=1528650682352809085,duration=6011521
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:008be7d6
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0b4cffe0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

ExpHP · Jun 10, 2018

extract_range<R: RangeBounds<usize>>(&mut [u8], range: R) -> (&mut [u8], &mut [u8], &mut [u8])

I was thinking of this myself. This is much like the issue faced by unzip, where the function that deals with 2 collections is incapable of being used as a building block for dealing with more than 2 collections.

Libraries often solve this sort of problem by making a trait for the output type and implementing it for many tuple sizes (or implementing it on a small set of combinator types), but I seldom see this in the standard library... almost as though we're waiting for variadic generics (yet nobody wants to admit it!).

joshlf · Jun 10, 2018

I was thinking of this myself. This is much like the issue faced by unzip, where the function that deals with 2 collections is incapable of being used as a building block for dealing with more than 2 collections. Libraries often solve this sort of problem by making a trait for the output type and implementing it for many tuple sizes (or implementing it on a small set of combinator types), but I seldom see this in the standard library... almost as though we're waiting for variadic generics (yet nobody wants to admit it!).

I'm happy to merge this as is and just keep an eye out for being able to add something like map_split_many in the future once we have a better mechanism for it.

ExpHP · Jun 10, 2018

It does make me wonder though if perhaps the standard library should simply expose a low-level API for this; one which might not be very ergonomic (it might even be unsafe), but which could be used to implement a method like map_split (for possibly more than 2 items) in a third-party crate.

(that said, doing so would ironically come at a much greater design cost, as care must be taken not to place unnecessary constraints on future evolution of the type)

Edit: Of course, I guess there's no real reason map_split couldn't come first. If two values are enough for most people, that's great! It's just that, once you need three things (and discover that there is literally no way), I think it'll feel half-baked.

bors · Jun 17, 2018

⌛️ Testing commit 2a999b4 with merge 7df0770...

bors · Jun 17, 2018

💔 Test failed - status-travis

rust-highfive · Jun 17, 2018

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:08:44] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[02:08:44] ; class=Net (12)
[02:09:41] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[02:09:41] ; class=Net (12)
[02:10:37] error: failed to load source for a dependency on `rand`
[02:10:37] Caused by:
[02:10:37]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[02:10:37] 
[02:10:37] Caused by:
[02:10:37] Caused by:
[02:10:37]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[02:10:37] 
[02:10:37] Caused by:
[02:10:37]   curl error: Couldn't resolve host 'github.com'
[02:10:37] ; class=Net (12)
[02:10:37] 
[02:10:37] 
[02:10:37] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[02:10:37] 
[02:10:37] 
[02:10:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[02:10:37] Build completed unsuccessfully in 2:07:36

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · Jun 17, 2018

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:08:44] warning: spurious network error (2 tries remaining): curl error: Couldn't resolve host 'github.com'
[02:08:44] ; class=Net (12)
[02:09:41] warning: spurious network error (1 tries remaining): curl error: Couldn't resolve host 'github.com'
[02:09:41] ; class=Net (12)
[02:10:37] error: failed to load source for a dependency on `rand`
[02:10:37] Caused by:
[02:10:37]   Unable to update registry `https://github.com/rust-lang/crates.io-index`
[02:10:37] 
[02:10:37] Caused by:
[02:10:37] Caused by:
[02:10:37]   failed to fetch `https://github.com/rust-lang/crates.io-index`
[02:10:37] 
[02:10:37] Caused by:
[02:10:37]   curl error: Couldn't resolve host 'github.com'
[02:10:37] ; class=Net (12)
[02:10:37] 
[02:10:37] 
[02:10:37] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "generate-lockfile" "--manifest-path" "/checkout/obj/build/tmp/distcheck-src/rust-src/lib/rustlib/src/rust/src/libstd/Cargo.toml"
[02:10:37] 
[02:10:37] 
[02:10:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[02:10:37] Build completed unsuccessfully in 2:07:36
---
travis_time:end:29f69a79:start=1529219337275068552,finish=1529219337281704535,duration=6635983
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08d229f6
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1d9e907a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · Jun 17, 2018

@bors retry travis-ci/travis-ci#9696

bors · Jun 17, 2018

⌛️ Testing commit 2a999b4 with merge aec00f9...

bors · Jun 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: dtolnay
Pushing aec00f9 to master...

nnethercote · Jun 19, 2018

This PR regressed compile time significantly, as shown by http://perf.rust-lang.org/compare.html?start=0f8f4903f73a21d7f408870551c08acd051abeb0&end=aec00f97e1cdcea2b079e209a7e759201ba6ca7c&stat=instructions:u

Almost all benchmarks in rustc-perf were affected, the worst by 4%.

@joshlf: Can you investigate?

CC @rust-lang/wg-compiler-performance

joshlf · Jun 28, 2018

@nnethercote 's concern has been addressed in #51630.

rust-highfive assigned shepmaster Jun 10, 2018

rust-highfive added the S-waiting-on-review label Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from 123f1f1 to 6f065e6 Jun 10, 2018

kennytm added the T-libs label Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from 3ab1411 to 80bcd16 Jun 10, 2018

kennytm added the T-lang label Jun 10, 2018

rust-highfive assigned dtolnay and unassigned shepmaster Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch from 80bcd16 to 62da8d6 Jun 10, 2018

joshlf referenced this pull request Jun 10, 2018
Closed
Tracking issue for Ref/RefMut::map_split #51476
2 of 2 tasks complete

joshlf force-pushed the joshlf:ref-split branch from 62da8d6 to e34f2e4 Jun 10, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 17, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jun 17, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 17, 2018

bors merged commit 2a999b4 into rust-lang:master Jun 17, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

joshlf deleted the joshlf:ref-split branch Jun 17, 2018

joshlf referenced this pull request Jun 19, 2018
Merged
Optimize RefCell refcount tracking #51630

joshlf referenced this pull request Jun 19, 2018
Closed
DO NOT MERGE: map_split perf test #51643

Mark-Simulacrum referenced this pull request Jun 27, 2018
Closed
Crate stable-borrow-state regressed in 1.28 beta #51840

rust-lang/rust

Join GitHub today

Add Ref/RefMut map_split method #51466

Conversation

joshlf commented Jun 10, 2018

rust-highfive assigned shepmaster Jun 10, 2018

This comment has been minimized.

rust-highfive commented Jun 10, 2018

rust-highfive added the S-waiting-on-review label Jun 10, 2018

This comment has been minimized.

rust-highfive commented Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from 123f1f1 to 6f065e6 Jun 10, 2018

kennytm added the T-libs label Jun 10, 2018

This comment has been minimized.

rust-highfive commented Jun 10, 2018

kennytm reviewed Jun 10, 2018 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from 3ab1411 to 80bcd16 Jun 10, 2018

This comment has been minimized.

rust-highfive commented Jun 10, 2018

This comment has been minimized.

Centril commented Jun 10, 2018

Centril reviewed Jun 10, 2018 View changes

Centril left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kennytm added the T-lang label Jun 10, 2018

This comment has been minimized.

shepmaster commented Jun 10, 2018

rust-highfive assigned dtolnay and unassigned shepmaster Jun 10, 2018

This comment has been minimized.

ExpHP commented Jun 10, 2018

dtolnay reviewed Jun 10, 2018 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dtolnay commented Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch from 80bcd16 to 62da8d6 Jun 10, 2018

This comment has been minimized.

joshlf commented Jun 10, 2018

dtolnay reviewed Jun 10, 2018 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-highfive commented Jun 10, 2018

joshlf referenced this pull request Jun 10, 2018

joshlf force-pushed the joshlf:ref-split branch from 62da8d6 to e34f2e4 Jun 10, 2018

This comment has been minimized.

ExpHP commented Jun 10, 2018 • edited

This comment has been minimized.

joshlf commented Jun 10, 2018

This comment has been minimized.

ExpHP commented Jun 10, 2018 • edited

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 17, 2018

This comment has been minimized.

bors commented Jun 17, 2018

bors added a commit that referenced this pull request Jun 17, 2018

This comment has been minimized.

bors commented Jun 17, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jun 17, 2018

This comment has been minimized.

rust-highfive commented Jun 17, 2018

This comment has been minimized.

rust-highfive commented Jun 17, 2018

This comment has been minimized.

kennytm commented Jun 17, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Jun 17, 2018

bors added a commit that referenced this pull request Jun 17, 2018

This comment has been minimized.

bors commented Jun 17, 2018

This comment has been minimized.

bors commented Jun 17, 2018

Hide details View details bors merged commit 2a999b4 into rust-lang:master Jun 17, 2018 2 checks passed

2 checks passed

joshlf deleted the joshlf:ref-split branch Jun 17, 2018

This comment has been minimized.

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from `123f1f1` to `6f065e6` Jun 10, 2018

kennytm reviewed Jun 10, 2018

View changes

joshlf force-pushed the joshlf:ref-split branch 2 times, most recently from `3ab1411` to `80bcd16` Jun 10, 2018

Centril reviewed Jun 10, 2018

View changes

dtolnay reviewed Jun 10, 2018

View changes

joshlf force-pushed the joshlf:ref-split branch from `80bcd16` to `62da8d6` Jun 10, 2018

dtolnay reviewed Jun 10, 2018

View changes

joshlf force-pushed the joshlf:ref-split branch from `62da8d6` to `e34f2e4` Jun 10, 2018

ExpHP commented Jun 10, 2018 •

edited

ExpHP commented Jun 10, 2018 •

edited

bors merged commit `2a999b4` into rust-lang:master Jun 17, 2018
2 checks passed