Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make span_fatal and parse_block public #51508

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Make span_fatal and parse_block public #51508

merged 1 commit into from
Jun 12, 2018

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Jun 11, 2018

span_fatal and parse_block were made private in #51265. These methods are used in stainless.

Related #51498 #51504

@PSeitz
Make span_fatal and parse_block public
6fd9ede 
span_fatal and parse_block  were made private in rust-lang#51265. These methods are used in stainless.

Related rust-lang#51498 rust-lang#51504
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 11, 2018

📌 Commit 6fd9ede has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2018
@bors
Copy link
Contributor

bors commented Jun 12, 2018

⌛ Testing commit 6fd9ede with merge a1aae29...

bors added a commit that referenced this pull request Jun 12, 2018
@bors
Auto merge of #51508 - PSeitz:master, r=Mark-Simulacrum
a1aae29 
Make span_fatal and parse_block public

span_fatal and parse_block  were made private in #51265. These methods are used in stainless.

Related #51498 #51504
@bors
Copy link
Contributor

bors commented Jun 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing a1aae29 to master...

@bors bors merged commit 6fd9ede into rust-lang:master Jun 12, 2018
@utkarshkukreti utkarshkukreti mentioned this pull request Jun 13, 2018
Closed
@PSeitz PSeitz mentioned this pull request Jun 14, 2018
Merged
PSeitz added a commit to PSeitz/rust that referenced this pull request Jun 16, 2018
@PSeitz
Follow up on rust-lang#51508, make parse_block public instead parse_b…
b1c0857 
…lock_expr

This is an follow up to rust-lang#51508

I mistakenly made parse_block_expr public instead of parse_block.
This fixes this.
bors added a commit that referenced this pull request Jun 17, 2018
@bors
Auto merge of #51549 - PSeitz:patch-1, r=kennytm
9181741 
Follow up to #51508, make parse_block public instead parse_block_expr

This is an follow up to #51508

I mistakenly made parse_block_expr public instead of parse_block.
This fixes this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PSeitz @rust-highfive @Mark-Simulacrum @bors @michaelwoerister