rustc: Disallow machine applicability in foreign macros #52756

alexcrichton · 2018-07-26T22:05:53Z

Recent changes to lints disallowed lints from being emitted against code located
in foreign macros, except for future-incompatible lints. For a future
incompatible lint, however, the automatic suggestions may not be applicable!

This commit updates this code path to force all applicability suggestions made
to foreign macros to never be MachineApplicable. This should avoid rustfix
actually attempting fixing these suggestions, causing non-compiling code to be
produced.

Closes rust-lang/cargo#5799

rust-highfive · 2018-07-26T22:05:56Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2018-07-26T22:06:01Z

r? @oli-obk

rust-highfive · 2018-07-26T22:21:58Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:03:49] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:49] tidy error: /checkout/src/tools/compiletest/src/header.rs:404: line longer than 100 chars
[00:03:50] some tidy checks failed
[00:03:50] 
[00:03:50] 
[00:03:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:50] 
[00:03:50] 
[00:03:50] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:50] Build completed unsuccessfully in 0:00:47
[00:03:50] Build completed unsuccessfully in 0:00:47
[00:03:50] Makefile:79: recipe for target 'tidy' failed
[00:03:50] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:012b5d34
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:27c58248:start=1532643126543659449,finish=1532643126550463924,duration=6804475
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:21049e30
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ce4e9f5
travis_time:start:0ce4e9f5
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:3b2b62cd
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-07-30T08:24:38Z

src/test/ui-fulldeps/rust-2018/suggestions-not-always-applicable.stderr

+  --> $DIR/suggestions-not-always-applicable.rs:27:5
+   |
+LL |     #[foo] //~ WARN: absolute paths must start with
+   |     ^^^^^^ help: use `crate`: `crate::#[foo]`


Since the suggestions still show up for the users, but are just ignored by rustfix, maybe we should rather not produce any suggestions in case of future incompatibility lints from external macros.

You already have the field in place in the Diagnostic type, this can be used to just not add any suggestions

Sounds good t ome!

oli-obk · 2018-07-30T08:25:59Z

src/librustc_errors/diagnostic_builder.rs

+        DiagnosticBuilder {
+            handler,
+            diagnostic,
+            allow_machine_applicable: false,


shouldn't this be true? I don't see any code that ever sets it to true, only to false, so the default should probably true

Ah yes, this is indeed a mistake

Recent changes to lints disallowed lints from being emitted against code located in foreign macros, except for future-incompatible lints. For a future incompatible lint, however, the automatic suggestions may not be applicable! This commit updates this code path to force all applicability suggestions made to foreign macros to never be `MachineApplicable`. This should avoid rustfix actually attempting fixing these suggestions, causing non-compiling code to be produced. Closes rust-lang/cargo#5799

alexcrichton · 2018-07-30T14:49:27Z

Updated!

oli-obk · 2018-07-30T15:17:34Z

@bors r+

bors · 2018-07-30T15:17:35Z

📌 Commit ca762ba has been approved by oli-obk

rustc: Disallow machine applicability in foreign macros Recent changes to lints disallowed lints from being emitted against code located in foreign macros, except for future-incompatible lints. For a future incompatible lint, however, the automatic suggestions may not be applicable! This commit updates this code path to force all applicability suggestions made to foreign macros to never be `MachineApplicable`. This should avoid rustfix actually attempting fixing these suggestions, causing non-compiling code to be produced. Closes rust-lang/cargo#5799

alexcrichton · 2018-07-31T18:54:31Z

@bors: p=1

needed for the edition preview!

bors · 2018-07-31T19:58:31Z

⌛ Testing commit ca762ba with merge 4edb9b38498cf7364d2f2cac00ea7c0a3ba56ace...

bors · 2018-07-31T20:52:11Z

💔 Test failed - status-travis

rust-highfive · 2018-07-31T20:52:12Z

The job dist-various-2 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:dpl_0
travis_time:start:1807540f
travis_fold:start:dpl.1
Installing deploy dependencies
ERROR:  Could not find a valid gem 'aws-sdk-core' (= 2.11.98) in any repository
ERROR:  Possible alternatives: aws-sdk-core
/home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- dpl/provider/s3 (LoadError)
 from /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:59:in `require'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/provider.rb:93:in `rescue in block in new'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/provider.rb:68:in `block in new'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/cli.rb:41:in `fold'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/provider.rb:67:in `new'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/cli.rb:31:in `run'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/lib/dpl/cli.rb:7:in `run'
 from /home/travis/.rvm/gems/ruby-2.2.7/gems/dpl-1.9.8/bin/dpl:5:in `<top (required)>'
 from /home/travis/.rvm/gems/ruby-2.2.7/bin/dpl:23:in `load'
 from /home/travis/.rvm/gems/ruby-2.2.7/bin/dpl:23:in `<main>'
failed to deploy

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-07-31T20:54:30Z

@bors: retry #44159

bors · 2018-08-01T00:08:31Z

⌛ Testing commit ca762ba with merge a1be95df794f4ba801dd1d29acbe14067a8dd7e6...

bors · 2018-08-01T01:24:13Z

💔 Test failed - status-travis

rust-highfive · 2018-08-01T01:24:14Z

The job dist-x86_64-freebsd of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:12:23] [TIMING] Std { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-freebsd" } -- 62.916
[01:12:23] Dist analysis
[01:12:23] image_src: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-freebsd/release/deps/save-analysis", dst: "/checkout/obj/build/tmp/dist/rust-analysis-nightly-x86_64-unknown-freebsd-image/lib/rustlib/x86_64-unknown-freebsd/analysis"

Broadcast message from root@travis-job-435ec36e-e0d3-4f78-8c41-f3ee3ea7013c
 (unknown) at 1:22 ...
The system is going down for power off NOW!
[01:12:24] 
[01:12:24] Session terminated, terminating shell... ...terminated.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 143.
travis_time:start:0179f751
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-08-01T01:36:28Z

@bors: retry

rustc: Disallow machine applicability in foreign macros Recent changes to lints disallowed lints from being emitted against code located in foreign macros, except for future-incompatible lints. For a future incompatible lint, however, the automatic suggestions may not be applicable! This commit updates this code path to force all applicability suggestions made to foreign macros to never be `MachineApplicable`. This should avoid rustfix actually attempting fixing these suggestions, causing non-compiling code to be produced. Closes rust-lang/cargo#5799

@ghost

Rollup of 31 pull requests Successful merges: - #52332 (dead-code lint: say "constructed" for structs) - #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr) - #52628 (Cleanup some rustdoc code) - #52732 (Remove unstable and deprecated APIs) - #52745 (Update clippy to latest master) - #52756 (rustc: Disallow machine applicability in foreign macros) - #52771 (Clarify thread::park semantics) - #52810 ([NLL] Don't make "fake" match variables mutable) - #52821 (pretty print for std::collections::vecdeque) - #52822 (Fix From<LocalWaker>) - #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper) - #52831 (remove references to AUTHORS.txt file) - #52835 (Fix Alias intra doc ICE) - #52842 (update comment) - #52846 (Add timeout to use of `curl` in bootstrap.py.) - #52851 (Make the tool_lints actually usable) - #52853 (Improve bootstrap help on stages) - #52859 (Use Vec::extend in SmallVec::extend when applicable) - #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.) - #52867 (releases.md: fix 2 typos) - #52870 (Implement Unpin for FutureObj and LocalFutureObj) - #52876 (run-pass/const-endianness: negate before to_le()) - #52878 (Fix wrong issue number in the test name) - #52883 (Include lifetime in mutability suggestion in NLL messages) - #52904 (NLL: sort diagnostics by span) - #52905 (Fix a typo in unsize.rs) - #52907 (NLL: On "cannot move out of type" error, print original before rewrite) - #52908 (Use SetLenOnDrop in Vec::truncate()) - #52914 (Only run the sparc-abi test on sparc) - #52918 (Backport 1.27.2 release notes) - #52929 (Update compatibility note for 1.28.0 to be correct) Failed merges: - #52758 (Cleanup for librustc::session) - #52799 (Use BitVector for global sets of AttrId) r? @ghost

bors · 2018-08-01T04:01:21Z

⌛ Testing commit ca762ba with merge 752e6a4b62628b2755cbc8c47fc1e6600ef3a085...

bors · 2018-08-01T05:02:10Z

💔 Test failed - status-travis

rust-highfive · 2018-08-01T05:02:12Z

The job wasm32-unknown of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:56:46] test [run-pass] run-pass/generic-temporary.rs ... ok
[00:56:47] test [run-pass] run-pass/generic-tup.rs ... ok
[00:56:47] test [run-pass] run-pass/generic-type-synonym.rs ... ok

Broadcast message from root@travis-job-0572b7bc-19da-4f33-a4e9-398943060518
 (unknown) at 5:00 ...
The system is going down for power off NOW!
[00:56:47] 
[00:56:47] Session terminated, terminating shell... ...terminated.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 143.
travis_time:start:0e195088
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-08-01T05:03:39Z

@bors: retry

bors · 2018-08-01T06:44:16Z

⌛ Testing commit ca762ba with merge c63bb1d...

rustc: Disallow machine applicability in foreign macros Recent changes to lints disallowed lints from being emitted against code located in foreign macros, except for future-incompatible lints. For a future incompatible lint, however, the automatic suggestions may not be applicable! This commit updates this code path to force all applicability suggestions made to foreign macros to never be `MachineApplicable`. This should avoid rustfix actually attempting fixing these suggestions, causing non-compiling code to be produced. Closes rust-lang/cargo#5799

phansch · 2018-08-01T07:44:10Z

cc travis-ci/travis-ci#4924 for the travis hosts shutting down

bors · 2018-08-01T08:41:30Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing c63bb1d to master...

rust-highfive assigned eddyb Jul 26, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2018

rust-highfive assigned oli-obk and unassigned eddyb Jul 26, 2018

alexcrichton mentioned this pull request Jul 26, 2018

cargo fix: Paths in attributes aren't automatically converted rust-lang/cargo#5795

Closed

alexcrichton mentioned this pull request Jul 26, 2018

"cargo fix" produces an error message and fails to apply the suggested fixes to the file rust-lang/cargo#5808

Closed

alexcrichton force-pushed the cap-applicable branch from 4ba06a6 to bb785c7 Compare July 26, 2018 22:42

oli-obk requested changes Jul 30, 2018

View reviewed changes

alexcrichton force-pushed the cap-applicable branch from bb785c7 to ca762ba Compare July 30, 2018 14:49

oli-obk approved these changes Jul 30, 2018

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2018

Mark-Simulacrum mentioned this pull request Jul 30, 2018

Rollup of 22 pull requests #52882

Closed

alexcrichton mentioned this pull request Jul 31, 2018

Epoch lints don't handle macros very well #48704

Closed

alexcrichton added this to the Rust 2018 Preview 2 milestone Jul 31, 2018

alexcrichton mentioned this pull request Jul 31, 2018

cargo fix - failure with Deserialize rust-lang/cargo#5799

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2018

Mark-Simulacrum mentioned this pull request Aug 1, 2018

Rollup of 31 pull requests #52931

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2018

bors merged commit ca762ba into rust-lang:master Aug 1, 2018

alexcrichton deleted the cap-applicable branch August 29, 2018 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustc: Disallow machine applicability in foreign macros #52756

rustc: Disallow machine applicability in foreign macros #52756

alexcrichton commented Jul 26, 2018

rust-highfive commented Jul 26, 2018

alexcrichton commented Jul 26, 2018

rust-highfive commented Jul 26, 2018

oli-obk Jul 30, 2018

alexcrichton Jul 30, 2018

oli-obk Jul 30, 2018

alexcrichton Jul 30, 2018

alexcrichton commented Jul 30, 2018

oli-obk commented Jul 30, 2018

bors commented Jul 30, 2018

alexcrichton commented Jul 31, 2018

bors commented Jul 31, 2018

bors commented Jul 31, 2018

rust-highfive commented Jul 31, 2018

alexcrichton commented Jul 31, 2018

bors commented Aug 1, 2018

bors commented Aug 1, 2018

rust-highfive commented Aug 1, 2018

alexcrichton commented Aug 1, 2018

bors commented Aug 1, 2018

bors commented Aug 1, 2018

rust-highfive commented Aug 1, 2018

alexcrichton commented Aug 1, 2018

bors commented Aug 1, 2018

phansch commented Aug 1, 2018

bors commented Aug 1, 2018

rustc: Disallow machine applicability in foreign macros #52756

rustc: Disallow machine applicability in foreign macros #52756

Conversation

alexcrichton commented Jul 26, 2018

rust-highfive commented Jul 26, 2018

alexcrichton commented Jul 26, 2018

rust-highfive commented Jul 26, 2018

oli-obk Jul 30, 2018

Choose a reason for hiding this comment

alexcrichton Jul 30, 2018

Choose a reason for hiding this comment

oli-obk Jul 30, 2018

Choose a reason for hiding this comment

alexcrichton Jul 30, 2018

Choose a reason for hiding this comment

alexcrichton commented Jul 30, 2018

oli-obk commented Jul 30, 2018

bors commented Jul 30, 2018

alexcrichton commented Jul 31, 2018

bors commented Jul 31, 2018

bors commented Jul 31, 2018

rust-highfive commented Jul 31, 2018

alexcrichton commented Jul 31, 2018

bors commented Aug 1, 2018

bors commented Aug 1, 2018

rust-highfive commented Aug 1, 2018

alexcrichton commented Aug 1, 2018

bors commented Aug 1, 2018

bors commented Aug 1, 2018

rust-highfive commented Aug 1, 2018

alexcrichton commented Aug 1, 2018

bors commented Aug 1, 2018

phansch commented Aug 1, 2018

bors commented Aug 1, 2018