Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM submodule to 7.0 #52983

Merged
merged 1 commit into from
Aug 5, 2018
Merged

Update LLVM submodule to 7.0 #52983

merged 1 commit into from
Aug 5, 2018

Conversation

alexcrichton
Copy link
Member

This commit updates the following submodules to LLVM's recently branched
7.0 release branch:

  • src/llvm
  • src/tools/lld
  • src/libcompiler_builtins/compiler-rt

Closes #52970

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2018
@alexcrichton
Copy link
Member Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned aturon Aug 2, 2018
@alexcrichton
Copy link
Member Author

I've confirmed that the LLVM 7 release branch includes the fix also needed in #52952

@cuviper
Copy link
Member

cuviper commented Aug 2, 2018

This rebase includes a couple other recent fixes that I was getting ready to submit. 😄

@kennytm
Copy link
Member

kennytm commented Aug 3, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2018

📌 Commit 0217459 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2018
@kennytm kennytm mentioned this pull request Aug 3, 2018
Closed
cramertj added a commit to cramertj/rust that referenced this pull request Aug 3, 2018
@cramertj
Rollup merge of rust-lang#52983 - alexcrichton:update-llvm, r=kennytm
a635638 
Update LLVM submodule to 7.0

This commit updates the following submodules to LLVM's [recently branched][1]
7.0 release branch:

* src/llvm
* src/tools/lld
* src/libcompiler_builtins/compiler-rt

[1]: https://lists.llvm.org/pipermail/llvm-dev/2018-August/125004.html

Closes rust-lang#52970
@cramertj cramertj mentioned this pull request Aug 3, 2018
Closed
@alexcrichton
Update LLVM submodule to 7.0
b0337a8 
This commit updates the following submodules to LLVM's [recently branched][1]
7.0 release branch:

* src/llvm
* src/tools/lld
* src/libcompiler_builtins/compiler-rt

[1]: https://lists.llvm.org/pipermail/llvm-dev/2018-August/125004.html

Closes rust-lang#52970
@alexcrichton
Copy link
Member Author

@bors: r=kennytm

@bors
Copy link
Contributor

bors commented Aug 5, 2018

📌 Commit b0337a8 has been approved by kennytm

@bors
Copy link
Contributor

bors commented Aug 5, 2018

⌛ Testing commit b0337a8 with merge f02752139639e5348753aac1f5a99346c98589e0...

@bors
Copy link
Contributor

bors commented Aug 5, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 5, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:18:09] -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
[00:18:09] -- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed
[00:18:09] -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
[00:18:09] -- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Failed
[00:18:09] -- Performing Test CXX_SUPPORTS_CLASS_MEMACCESS_FLAG
[00:18:09] -- Performing Test CXX_SUPPORTS_CLASS_MEMACCESS_FLAG - Failed
[00:18:09] -- Performing Test C_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG - Failed
[00:18:09] -- Performing Test CXX_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG
[00:18:09] -- Performing Test CXX_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG - Success
[00:18:09] -- Performing Test C_WCOMMENT_ALLOWS_LINE_WRAP
---
[00:18:13] [  0%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/AMDGPUMetadata.cpp.o
[00:18:13] [  0%] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/JSONBackend.cpp.o
[00:18:14] [  0%] Building CXX object lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o
[00:18:14] [  0%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APFloat.cpp.o
[00:18:14] In file included from /checkout/src/llvm/lib/TableGen/JSONBackend.cpp:20:0:
[00:18:14] /checkout/src/llvm/include/llvm/Support/JSON.h:393:23:   required from here
[00:18:14] /checkout/src/llvm/include/llvm/Support/JSON.h:455:47: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
[00:18:14]      return *reinterpret_cast<T *>(Union.buffer);
[00:18:14]                                                ^
---
[00:20:52] [ 67%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMRegisterInfo.cpp.o
[00:20:52] [ 67%] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86ShuffleDecodeConstantPool.cpp.o
[00:20:52] [ 67%] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64CallLowering.cpp.o
[00:20:53] [ 67%] Building CXX object lib/Target/AArch64/Disassembler/CMakeFiles/LLVMAArch64Disassembler.dir/AArch64ExternalSymbolizer.cpp.o
[00:20:53] [ 67%] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86SpeculativeLoadHardening.cpp.o
[00:20:53] [ 67%] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64CleanupLocalDynamicTLSPass.cpp.o
[00:20:53] [ 67%] Linking CXX static library ../../../libLLVMAArch64Disassembler.a
[00:20:53] make[3]: Leaving directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:20:53] [ 67%] Built target LLVMAArch64Disassembler
---
[00:21:27] Scanning dependencies of target LLVMHexagonDisassembler
[00:21:27] make[3]: Leaving directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:21:27] make[3]: Entering directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:21:27] [ 81%] Building CXX object lib/Target/Hexagon/Disassembler/CMakeFiles/LLVMHexagonDisassembler.dir/HexagonDisassembler.cpp.o
[00:21:27] /checkout/src/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp: In function 'virtual bool {anonymous}::BitSimplification::processBlock(llvm::MachineBasicBlock&, const {anonymous}::RegisterSet&)':
[00:21:27] /checkout/src/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp:1989:16: warning: 'V' is used uninitialized in this function [-Wuninitialized]
[00:21:27]    if (!isInt<8>(V))
[00:21:27]                 ^
[00:21:27] /checkout/src/llvm/lib/Target/Hexagon/HexagonBitSimplify.cpp:1977:7: note: 'V' was declared here
[00:21:27]    int V;
[00:21:27] [ 81%] Building CXX object lib/Target/Hexagon/CMakeFiles/LLVMHexagonCodeGen.dir/HexagonBlockRanges.cpp.o
[00:21:27] [ 81%] Building CXX object lib/Target/NVPTX/CMakeFiles/LLVMNVPTXCodeGen.dir/NVPTXRegisterInfo.cpp.o
[00:21:27] [ 81%] Building CXX object lib/Target/Hexagon/CMakeFiles/LLVMHexagonCodeGen.dir/HexagonBranchRelaxation.cpp.o
[00:21:27] [ 81%] Linking CXX static library ../../../libLLVMHexagonDisassembler.a
---
[00:21:30] [ 82%] Building CXX object lib/Target/Hexagon/MCTargetDesc/CMakeFiles/LLVMHexagonDesc.dir/HexagonInstPrinter.cpp.o
[00:21:30] Scanning dependencies of target LLVMWebAssemblyCodeGen
[00:21:30] make[3]: Leaving directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:21:30] make[3]: Entering directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:21:30] [ 82%] Building CXX object lib/Target/WebAssembly/CMakeFiles/LLVMWebAssemblyCodeGen.dir/WebAssemblyAddMissingPrototypes.cpp.o
[00:21:30] [ 82%] Building CXX object lib/Target/WebAssembly/CMakeFiles/LLVMWebAssemblyCodeGen.dir/WebAssemblyArgumentMove.cpp.o
[00:21:30] [ 82%] Building CXX object lib/Target/Hexagon/MCTargetDesc/CMakeFiles/LLVMHexagonDesc.dir/HexagonMCAsmInfo.cpp.o
[00:21:30] [ 82%] Building CXX object lib/Target/WebAssembly/CMakeFiles/LLVMWebAssemblyCodeGen.dir/WebAssemblyAsmPrinter.cpp.o
[00:21:30] [ 82%] Building CXX object lib/Target/Hexagon/CMakeFiles/LLVMHexagonCodeGen.dir/HexagonFrameLowering.cpp.o
---
[00:22:17] Scanning dependencies of target llvm-undname
[00:22:17] make[3]: Leaving directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:22:17] make[3]: Entering directory '/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build'
[00:22:17] [ 98%] Building CXX object tools/llvm-mca/CMakeFiles/llvm-mca.dir/Stage.cpp.o
[00:22:17] [ 98%] Building CXX object tools/llvm-undname/CMakeFiles/llvm-undname.dir/llvm-undname.cpp.o
[00:22:18] [ 99%] Building CXX object tools/llvm-mca/CMakeFiles/llvm-mca.dir/Support.cpp.o
[00:22:18] [ 99%] Linking CXX executable ../../bin/llvm-undname
[00:22:18] [ 99%] Building CXX object tools/llvm-cov/CMakeFiles/llvm-cov.dir/CoverageSummaryInfo.cpp.o
[00:22:18] [ 99%] Building CXX object tools/llvm-mca/CMakeFiles/llvm-mca.dir/SummaryView.cpp.o
---
[00:48:24] [RUSTC-TIMING] aho_corasick test:false 1.401
[00:48:25] [RUSTC-TIMING] tempfile test:false 2.306
[00:48:31] [RUSTC-TIMING] regex_syntax test:false 19.977

Broadcast message from root@travis-job-720e4a93-aacc-4595-9d5f-b97ef701e1ec
 (unknown) at 12:18 ...
The system is going down for power off NOW!
[00:48:41] Makefile:28: recipe for target 'all' failed
[00:48:41] Makefile:28: recipe for target 'all' failed
[00:48:41] Session terminated, terminating shell... ...terminated.
[00:48:41] make: *** [all] Terminated

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 143.
travis_time:start:11a57d62
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Aug 5, 2018

@bors retry travis-ci/travis-ci#4924

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 5, 2018
@bors
Copy link
Contributor

bors commented Aug 5, 2018

⌛ Testing commit b0337a8 with merge 93a4cab...

bors added a commit that referenced this pull request Aug 5, 2018
@bors
Auto merge of #52983 - alexcrichton:update-llvm, r=kennytm
93a4cab 
Update LLVM submodule to 7.0

This commit updates the following submodules to LLVM's [recently branched][1]
7.0 release branch:

* src/llvm
* src/tools/lld
* src/libcompiler_builtins/compiler-rt

[1]: https://lists.llvm.org/pipermail/llvm-dev/2018-August/125004.html

Closes #52970
@bors
Copy link
Contributor

bors commented Aug 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 93a4cab to master...

@bors bors merged commit b0337a8 into rust-lang:master Aug 5, 2018
@nnethercote
Copy link
Contributor

Unfortunately this regressed compile speed across a lot of benchmarks, by up to 2.7%:
https://perf.rust-lang.org/compare.html?start=9f9ac89d11a2afaeaa029738b38142124684c89b&end=93a4cab45ad119003c9749861eb7ac749eb334e2&stat=instructions:u

Probably not a lot we can do about it, though :(

@alexcrichton alexcrichton deleted the update-llvm branch August 20, 2018 16:20
This was referenced Jul 14, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alexcrichton @rust-highfive @cuviper @kennytm @bors @nnethercote @aturon