Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some suggestions as MachineApplicable #53418

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Mark some suggestions as MachineApplicable #53418

merged 1 commit into from
Aug 22, 2018

Conversation

ekse
Copy link
Contributor

@ekse ekse commented Aug 16, 2018

I think the following suggestions should be safe to mark as MachineApplicable.

r? @estebank

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2018
@ekse ekse mentioned this pull request Aug 16, 2018
Closed
@estebank
Copy link
Contributor

@ekse sorry for the delay in reviewing! RustConf has gotten in the way of keeping up :)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 17, 2018

📌 Commit e665715 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2018
@ekse
Copy link
Contributor Author

ekse commented Aug 17, 2018

No worries! I hope you're having a great time at the conference.

@bors
Copy link
Contributor

bors commented Aug 18, 2018

⌛ Testing commit e665715 with merge 66e2dfe...

bors added a commit that referenced this pull request Aug 18, 2018
@bors
Auto merge of #53418 - ekse:suggestions-applicability, r=estebank
66e2dfe 
Mark some suggestions as MachineApplicable

I think the following suggestions should be safe to mark as `MachineApplicable`.

r? @estebank
@bors
Copy link
Contributor

bors commented Aug 18, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2018
@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:33:11] test time::tests::system_time_elapsed ... ok
[01:33:11] test time::tests::system_time_math ... ok
[01:33:16] test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok
[01:33:17] test collections::hash::map::test_map::test_lots_of_insertions ... ok
[01:33:51] test process::tests::test_process_output_fail_to_start ... test process::tests::test_process_output_fail_to_start has been running for over 60 seconds
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank
Copy link
Contributor

@bors retry seems spurious to me.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 19, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#53418 - ekse:suggestions-applicability, r=e…
656ebf6 
…stebank

Mark some suggestions as MachineApplicable

I think the following suggestions should be safe to mark as `MachineApplicable`.

r? @estebank
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Aug 19, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 22, 2018
@GuillaumeGomez
Rollup merge of rust-lang#53418 - ekse:suggestions-applicability, r=e…
8255f9e 
…stebank

Mark some suggestions as MachineApplicable

I think the following suggestions should be safe to mark as `MachineApplicable`.

r? @estebank
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 22, 2018
Merged
bors added a commit that referenced this pull request Aug 22, 2018
@bors
Auto merge of #53607 - GuillaumeGomez:rollup, r=GuillaumeGomez
f1b506a 
Rollup of 10 pull requests

Successful merges:

 - #53418 (Mark some suggestions as MachineApplicable)
 - #53431 (Moved some feature gate ui tests to correct location)
 - #53442 (Update version of rls-data used with save-analysis)
 - #53504 (Set applicability for more suggestions.)
 - #53541 (Fix missing impl trait display as ret type)
 - #53544 (Point at the trait argument when using unboxed closure)
 - #53558 (Normalize source line and column numbers.)
 - #53562 (Lament the invincibility of the Turbofish)
 - #53574 (Suggest direct raw-pointer dereference)
 - #53585 (Remove super old comment on function that parses items)

Failed merges:

 - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.)
 - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into())

r? @ghost
@bors bors merged commit e665715 into rust-lang:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ekse @rust-highfive @estebank @bors