Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] Be more permissive when checking access due to Match #53438

Merged
merged 9 commits into from
Sep 25, 2018
Merged

[NLL] Be more permissive when checking access due to Match #53438

merged 9 commits into from
Sep 25, 2018

Commits on Sep 24, 2018

  1. Add "Shallow" borrow kind 

    This allows treating the "fake" match borrows differently from shared
borrows.
    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    ced5c2d View commit details
    Browse the repository at this point in the history

  2. Better messages for errors from Shallow borrows

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    b55bb2e View commit details
    Browse the repository at this point in the history

  3. Add more fake borrows to matches

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    a6fad3f View commit details
    Browse the repository at this point in the history

  4. Don't check for conflicting borrows of ReadForMatches

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    46e247b View commit details
    Browse the repository at this point in the history

  5. Add tests for new match borrows

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    c5047cb View commit details
    Browse the repository at this point in the history

  6. Update ui tests

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    1a6ed02 View commit details
    Browse the repository at this point in the history

  7. Add a MIR transform to remove fake reads 

    As we are now creating borrows of places that may not be valid for
borrow checking matches, these have to be removed to avoid generating
broken code.
    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    f71f733 View commit details
    Browse the repository at this point in the history

  8. Update mir opt tests

    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    531e98a View commit details
    Browse the repository at this point in the history

  9. Rename places_conflict to borrow_conflicts_with_place 

    This name better reflects the asymmetry of this function.
    @matthewjasper
    matthewjasper committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    a830732 View commit details
    Browse the repository at this point in the history