[Do not merge] Allow generic parameters to be specified in expressions without ::
#53511
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
|
⌛ Trying commit 255468e with merge ea8007c6cfa49b8dce63680b3993b974bbc0c6d4... |
|
You can r? @ghost as well, same as we do for rollup PRs automatically. |
Ah, neat, thanks! |
|
☀️ Test successful - status-travis |
|
@rust-timer build ea8007c6cfa49b8dce63680b3993b974bbc0c6d4 |
This comment has been minimized.
This comment has been minimized.
|
Success: Queued ea8007c6cfa49b8dce63680b3993b974bbc0c6d4 with parent f28f648, comparison URL. |
|
@bors try |
|
⌛ Trying commit ca4eb90 with merge 670e75fae5ca5024e3e2ec5903f7c41a0fe58e62... |
This comment has been minimized.
This comment has been minimized.
|
☀️ Test successful - status-travis |
|
@rust-timer build 670e75fae5ca5024e3e2ec5903f7c41a0fe58e62 |
|
Success: Queued 670e75fae5ca5024e3e2ec5903f7c41a0fe58e62 with parent bf1e461, comparison URL. |
|
rust-lang/rfcs#2527 has now been opened following the discoveries here. |
|
While this is feasible from a performance perspective, there are additional grammar ambiguities I had not considered. Sadly this experiment must remain that. |
[Do not merge] Optional turbofish breakage test As an academic exercise, to satisfy ourselves that we completely understand the lay of the land, we'd like to see how often ambiguous cases arise in real-world Rust code. (Following on from #53511.) @rust-lang/infra: is it possible to get a check-only crater run for this change? r? @ghost
…nagisa Lament the invincibility of the Turbofish Here a test case is added to ensure that any others attempting to drive the Turbofish to extinction have second thoughts. Previously the [entire test suite would succeed](rust-lang#53511) if generic arguments were accepted without disambiguation, making for [confusing and heartbreaking circumstances](rust-lang/rfcs#2527).
…nagisa Lament the invincibility of the Turbofish Here a test case is added to ensure that any others attempting to drive the Turbofish to extinction have second thoughts. Previously the [entire test suite would succeed](rust-lang#53511) if generic arguments were accepted without disambiguation, making for [confusing and heartbreaking circumstances](rust-lang/rfcs#2527).
…nagisa Lament the invincibility of the Turbofish Here a test case is added to ensure that any others attempting to drive the Turbofish to extinction have second thoughts. Previously the [entire test suite would succeed](rust-lang#53511) if generic arguments were accepted without disambiguation, making for [confusing and heartbreaking circumstances](rust-lang/rfcs#2527).
[Do not merge] Optional turbofish breakage test As an academic exercise, to satisfy ourselves that we completely understand the lay of the land, we'd like to see how often ambiguous cases arise in real-world Rust code. (Following on from #53511.) @rust-lang/infra: is it possible to get a check-only crater run for this change? r? @ghost
Note: this PR is an experiment in making the
::generics disambiguation in expressions optional. It is not intended to be merged. Any serious consideration of such a change would be subject to the full RFC process.I was almost ready to move on, then I realised I had made a silly mistake in the last experiment. I wanted to just see whether this small optimisation made a difference or not.
(I closed the old branch on #53074, so I had to open a new PR.)
r? @varkor (not sure if this works, to avoid pinging anyone unnecessarily)