submodules: update rls

[matthiaskrgr]

No description provided.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[alexcrichton]

@bors: r+

[bors]

📌 Commit 4572b84446aa1587f123700cc5dff4e1278fb317 has been approved by alexcrichton

[matthiaskrgr]

There was no nightly released because of bad toolstate (rls failed to build)
https://rust-lang-nursery.github.io/rust-toolstate/
rls failed to build because its clippy-lints dependency failed to build.
I updated the clippy-lints dep of rls to a state that is compatible with current rustc so hopefully this commit fixes the toolstate.
Or maybe I am misunderstanding things...

[nrc]

Is this updating to a branch? Because if not I think it won't work - building master RLS locally with the latest Rust commit fails in Clippy

[matthiaskrgr]

Yeah ... clippy just rebroke ... :(
#53581 (comment)

I'll see if I can get this fixed.

[alexcrichton]

@bors: r-

ah ok, removing from the queue in the meantime!

Also...

r? @nrc

[matthiaskrgr]

I updated again, should get rls to the same state as #53638

[nrc]

@bors: r+ p=10

[bors]

📌 Commit ba71a79c36edfdd16ce5d6a8b5d0b5fe2de4182d has been approved by nrc

[rust-highfive]

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##################################################                        69.8%
######################################################################## 100.0%
[00:01:58] extracting /checkout/obj/build/cache/2018-08-01/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:00]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:23] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:23] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:23] Makefile:81: recipe for target 'prepare' failed
[00:02:23] make: *** [prepare] Error 1
[00:02:24] Command failed. Attempt 2/5:
[00:02:24]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:24]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:25] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:25] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:25] Makefile:81: recipe for target 'prepare' failed
[00:02:25] make: *** [prepare] Error 1
[00:02:27] Command failed. Attempt 3/5:
[00:02:27]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:27]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:27] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:27] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:27] Makefile:81: recipe for target 'prepare' failed
[00:02:27] make: *** [prepare] Error 1
[00:02:30] Command failed. Attempt 4/5:
[00:02:30]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:30]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:31] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:31] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:31] Makefile:81: recipe for target 'prepare' failed
[00:02:31] make: *** [prepare] Error 1
[00:02:35] Command failed. Attempt 5/5:
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:02:35] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:35] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:02:35] Makefile:81: recipe for target 'prepare' failed
[00:02:35] make: *** [prepare] Error 1
[00:02:35] The command has failed after 5 attempts.
travis_time:end:0dcfbeea:start=1535064729664454389,finish=1535064891877610796,duration=162213156407
---
travis_time:end:006157ad:start=1535064892370594622,finish=1535064892383636310,duration=13041688
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05f3b9cd
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:039d02b7
travis_time:start:039d02b7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01edb894
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[nrc]

@bors: r+

[bors]

📌 Commit 493a5ca34a0dfbb2f7832b2265f55b5027c80277 has been approved by nrc

[matthiaskrgr]

Fixed via rust-lang/rls#1010 and rebased.

[kennytm]

@matthiaskrgr how about json_internal!?

[matthiaskrgr]

@kennytm I can't reproduce this one locally anymore,

I tried:

cargo +master build
cargo +master build --all-targets
cargo +master build --all-features
cargo +master build --all-features --all-targets

but all passed.
If you have any ideas please let me know!

[kennytm]

Let's see what bors think then.

@bors r=nrc

[bors]

📌 Commit 6c034fa has been approved by nrc

[bors]

⌛ Testing commit 6c034fa with merge e2b95da305eb10849938f27f7e3d78d2fa172676...

[bors]

💔 Test failed - status-appveyor

[kennytm]

Looks like the error is only reproducible on Windows.

[matthiaskrgr]

Ok, then there is nothing I can do about it since I don't have a windows machine.
I'll leave this to someone else then...

[Xanewok]

I can take a look at the Windows error later today.

[Xanewok]

Verified the fix in rust-lang/rls#1013 locally, so when that lands we should update RLS to pull that instead.