add more Cortex-R targets #53679
Merged
add more Cortex-R targets #53679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Oh, and examples of actual devices for each Cortex-R target
|
japaric
commented
Aug 24, 2018
|
|
||
| ENV CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc \ | ||
| CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc \ | ||
| CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc \ | ||
| CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc | ||
| CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc \ | ||
| CC_armebv7r_none_eabi=arm-none-eabi-gcc |
There was a problem hiding this comment.
We can drop this once rust-lang/cc-rs#341 is available in a new release but no need to block on that
|
Looks good to me! r=me with a |
|
@paoloteti @parched are you OK with landing this as it is? |
|
LGTM |
|
LGTM and thanks for the extra patches |
|
☔ The latest upstream changes (presumably #53662) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r=alexcrichton |
|
📌 Commit 99922847a6dd7aab2da5165d9c61ed5fad3cc45e has been approved by |
bors
added
S-waiting-on-bors
|
@japaric @pablobm @alexcrichton @parched Thanks for making this happen! 🎊 |
|
☔ The latest upstream changes (presumably #53567) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Similar to `armebv7r-none-eabihf`, but for Little-endian MCUs. As example TI RM4x/RM5x are Little-endian Cortex-R4F/R5F MCUs. CI/Dockerfile is intentionally in the disabled folder.
by removing the redundant +v7 feature
|
Rebased @bors r=alexcrichton |
|
📌 Commit 521df79 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 28, 2018
add more Cortex-R targets This expands on PR #53663 to complete the set of Cortex-R targets and builds rust-std components for them. r? @alexcrichton each extra rust-std component (there's 4 of them) takes about 3 minutes to build on my local machine. In terms of stability (LLVM codegen bugs) these new targets should be as stable as the Cortex-M ones (e.g. `thumbv7m-none-eabi`). If the extra build time is too much we can leave the rust-std components out for now closes #53663 cc @paoloteti
|
☀️ Test successful - status-appveyor, status-travis |
6 tasks
bors bot
added a commit
to rust-embedded/wg
that referenced
this pull request
Sep 6, 2018
199: [RFC] initial Cortex-R team r=japaric a=japaric This is a proposal for creating a Cortex-R team. @paoloteti and I will be the initial members. I know pretty much nothing about the Cortex-R but will be working with them starting November; @paoloteti is the real expert here. The following work has been planed for this team (some of it has been done already) - [x] Add more built-in targets to cover existing devices. In rust-lang/rust#53679 we went from 1 target to 4. We now have good coverage of Cortex R4(F) and R5(F) cores. - [x] Move to LLD to remove the dependency on a external linker. Done in rust-lang/rust#53679. - [x] Produce `rust-std` components to not depend on tools like Xargo, which require nightly. Also done in rust-lang/rust#53679. - [ ] Create a `cortex-r` crate (\*) akin to the `cortex-m` crate that provides a safe API to emit arch-specific instructions and to manipulate system registers. - [ ] Create a `cortex-r-rt` crate (\*) akin to the `cortex-m-rt` crate that helps building a minimal `no_std` binary. - [ ] See if we can generate register APIs from the XML files that vendors like TI ship with their IDEs. (\*) Initial work in this area: https://github.com/paoloteti/ti-hercules-bsp @rust-embedded/all please vote on this proposal using [GitHub reviews][approve]. This proposal needs at least 11 approvals to land (/all has 21 members atm). [approve]: https://help.github.com/articles/approving-a-pull-request-with-required-reviews/ Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on PR #53663 to complete the set of Cortex-R targets and builds
rust-std components for them.
r? @alexcrichton
each extra rust-std component (there's 4 of them) takes about 3 minutes to build
on my local machine. In terms of stability (LLVM codegen bugs) these new targets
should be as stable as the Cortex-M ones (e.g.
thumbv7m-none-eabi).If the extra build time is too much we can leave the rust-std components out for
now
closes #53663
cc @paoloteti