Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLL: Deduplicate errors for incorrect move in loop #53995

Merged
merged 3 commits into from
Sep 19, 2018
Merged

NLL: Deduplicate errors for incorrect move in loop #53995

merged 3 commits into from
Sep 19, 2018

Commits on Sep 18, 2018

  1. Log when buffering a diagnostic. 

    This is useful in debugging when and where errors are emitted in
logs.
    @davidtwco
    davidtwco committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    874e08b View commit details
    Browse the repository at this point in the history

  2. De-duplicate moved variable errors. 

    By introducing a new map that tracks the errors reported and the
`Place`s that spawned those errors against the move out that the error
was referring to, we are able to silence duplicate errors by emitting
only the error which corresponds to the most specific `Place` (that which
other `Place`s which reported errors are prefixes of).

This generally is an improvement, however there is a case -
`liveness-move-in-while` - where the output regresses.
    @davidtwco
    davidtwco committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    783bad4 View commit details
    Browse the repository at this point in the history

  3. Switched from FxHashMap to BTreeMap to preserve ordering when iterating.

    @davidtwco
    davidtwco committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    88ca341 View commit details
    Browse the repository at this point in the history