Make NonNull::dangling a const fn #54657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
dangling_const
branch
from
1e1fe9e
to
a493308
Compare
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
dangling_const
branch
from
a493308
to
fcc7671
Compare
This comment has been minimized.
This comment has been minimized.
|
Why is |
|
It seems that this is due to #53555, closing for now. |
Centril
reviewed
Sep 30, 2018
| @@ -2874,10 +2874,9 @@ impl<T: Sized> NonNull<T> { | |||
| /// sentinel value. Types that lazily allocate must track initialization by | |||
| /// some other means. | |||
| #[stable(feature = "nonnull", since = "1.25.0")] | |||
| pub fn dangling() -> Self { | |||
| pub const fn dangling() -> Self { | |||
There was a problem hiding this comment.
you can add:
#[rustc_const_unstable(feature = "const_ptr_dangling")]and I think it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for other
const fnconstructors