Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "cannot encode region variables" error #5467

Merged
merged 3 commits into from
Mar 26, 2013
Merged

Fix "cannot encode region variables" error #5467

merged 3 commits into from
Mar 26, 2013

Commits on Mar 26, 2013

  1. Rip out old code that still structured method calls as a 

    expr_call(expr_field(...)) rather than an expr_method_call.
There is probably more such code in trans that should be removed.
    @nikomatsakis
    nikomatsakis committed Mar 26, 2013
    Configuration menu
    Copy the full SHA
    e11d13f View commit details
    Browse the repository at this point in the history

  2. Add various debug statements to trans that I used to help track down the 

    problem and which seem like they could be useful in the future.
    @nikomatsakis
    nikomatsakis committed Mar 26, 2013
    Configuration menu
    Copy the full SHA
    6f2783d View commit details
    Browse the repository at this point in the history

  3. Stop writing directly to the final type/method/vtable sidetables from… 

    … astconv

and from typeck, which is verboten.  We are supposed to write inference results
into the FnCtxt and then these get copied over in writeback.  Add assertions
that no inference by-products are added to this table.

Fixes rust-lang#3888
Fixes rust-lang#4036
Fixes rust-lang#4492
    @nikomatsakis
    nikomatsakis committed Mar 26, 2013
    5 Configuration menu
    Copy the full SHA
    3ca7c22 View commit details
    Browse the repository at this point in the history