Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary comma in libstd/thread/mod.rs doc comment #54871

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Remove unnecessary comma in libstd/thread/mod.rs doc comment #54871

merged 1 commit into from
Oct 8, 2018

Conversation

awaitlink
Copy link
Contributor

Fix typo in libstd/thread/mod.rs doc comment: remove unnecessary comma.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aidanhs (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2018
frewsxcv
frewsxcv approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@frewsxcv
Copy link
Member

frewsxcv commented Oct 6, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 6, 2018

📌 Commit ddcec08 has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2018
@bors
Copy link
Contributor

bors commented Oct 8, 2018

⌛ Testing commit ddcec08 with merge 423d810...

bors added a commit that referenced this pull request Oct 8, 2018
@bors
Auto merge of #54871 - u32i64:master, r=frewsxcv
423d810 
Remove unnecessary comma in `libstd/thread/mod.rs` doc comment

Fix typo in `libstd/thread/mod.rs` doc comment: remove unnecessary comma.
@bors
Copy link
Contributor

bors commented Oct 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 423d810 to master...

@bors bors merged commit ddcec08 into rust-lang:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@aidanhs aidanhs

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@awaitlink @rust-highfive @frewsxcv @bors @aidanhs